Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-12510: Replace getDiagnosticData for connection tests #2754

Merged
merged 8 commits into from
Jan 16, 2024

Conversation

idoqo
Copy link
Contributor

@idoqo idoqo commented Jan 10, 2024

PMM-12510

Link to the Feature Build: SUBMODULES-3483

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

@idoqo idoqo requested a review from a team as a code owner January 10, 2024 05:30
@idoqo idoqo requested review from BupycHuk and JiriCtvrtka and removed request for a team January 10, 2024 05:30
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (ce0fbe8) 42.00% compared to head (974cc49) 42.18%.
Report is 2 commits behind head on main.

Files Patch % Lines
agent/connectionchecker/connection_checker.go 62.96% 7 Missing and 3 partials ⚠️
agent/utils/version/mongo.go 47.05% 6 Missing and 3 partials ⚠️
agent/serviceinfobroker/service_info_broker.go 50.00% 1 Missing and 1 partial ⚠️
managed/services/agents/service_info_broker.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2754      +/-   ##
==========================================
+ Coverage   42.00%   42.18%   +0.17%     
==========================================
  Files         395      396       +1     
  Lines       50048    50077      +29     
==========================================
+ Hits        21023    21125     +102     
+ Misses      27025    26950      -75     
- Partials     2000     2002       +2     
Flag Coverage Δ
agent 53.18% <56.25%> (+0.83%) ⬆️
managed 42.73% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@idoqo idoqo requested a review from BupycHuk January 11, 2024 06:57
@idoqo idoqo merged commit 4aa0e4c into main Jan 16, 2024
23 checks passed
@idoqo idoqo deleted the PMM-12510-connect-to-arbiter branch January 16, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants