Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PMM-9825 use username instead of userid #2718

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

BupycHuk
Copy link
Member

PMM-9825

Link to the Feature Build: SUBMODULES-3491

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@BupycHuk BupycHuk requested review from JiriCtvrtka and a team as code owners December 20, 2023 12:44
@BupycHuk BupycHuk requested review from ademidoff and idoqo and removed request for a team December 20, 2023 12:44
Copy link

codecov bot commented Dec 20, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6ed69a8) 42.18% compared to head (164641f) 42.24%.
Report is 9 commits behind head on main.

Files Patch % Lines
...nts/postgres/pgstatmonitor/pgstatmonitor_models.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2718      +/-   ##
==========================================
+ Coverage   42.18%   42.24%   +0.06%     
==========================================
  Files         395      395              
  Lines       50040    49972      -68     
==========================================
+ Hits        21110    21113       +3     
+ Misses      26932    26871      -61     
+ Partials     1998     1988      -10     
Flag Coverage Δ
agent 53.39% <80.00%> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BupycHuk BupycHuk changed the title PMM-9825-use-username-instead-userid PMM-9825 use username instead of userid Dec 21, 2023
@BupycHuk BupycHuk enabled auto-merge (squash) January 8, 2024 09:08
@BupycHuk BupycHuk disabled auto-merge January 8, 2024 12:13
@BupycHuk BupycHuk merged commit 0da709d into main Jan 8, 2024
22 checks passed
@BupycHuk BupycHuk deleted the PMM-9825-use-username-instead-userid branch January 8, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants