PMM-12422 use public IP for exporters in pull mode #2642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
=======================================
Coverage 42.61% 42.61%
=======================================
Files 396 396
Lines 49939 49939
=======================================
Hits 21283 21283
Misses 26665 26665
Partials 1991 1991
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
idoqo
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
idoqo
changed the title
BupycHuk
approved these changes
Nov 27, 2023
ademidoff
approved these changes
Nov 27, 2023
| return "127.0.0.1" | ||
| default: |
There was a problem hiding this comment.
It seems like this makes the first case redundant.
There was a problem hiding this comment.
Yeah true - I wanted to keep the case where exposeExporter is enabled at the top so it overrides anything else.
artemgavrilov
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12422
Due to issues with getting metrics when using the node IP, this exposes exporters running in pull mode on the public IP address.
Link to the Feature Build: SUBMODULES-0