PMM-12643 consistent types in list output of pmm-admin #2616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ademidoff
requested review from
BupycHuk and
JiriCtvrtka
and removed request for
a team
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2616 +/- ##
==========================================
+ Coverage 42.09% 42.21% +0.12%
==========================================
Files 395 395
Lines 49969 49974 +5
==========================================
+ Hits 21035 21099 +64
+ Misses 26965 26886 -79
- Partials 1969 1989 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BupycHuk
reviewed
Nov 10, 2023
Did you mean if we can add a test for RunCmd? |
BupycHuk
approved these changes
Nov 13, 2023
JiriCtvrtka
approved these changes
Nov 16, 2023
…f github.com:percona/pmm into PMM-12643-type-consistency-in-admin-json-list-result
ademidoff
deleted the
PMM-12643-type-consistency-in-admin-json-list-result
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12643
Link to the Feature Build: SUBMODULES-3445