Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PMM-12529 Run pmm-agent as non root #2590

Merged
merged 22 commits into from
Nov 30, 2023
Merged

PMM-12529 Run pmm-agent as non root #2590

merged 22 commits into from
Nov 30, 2023

Conversation

ademidoff
Copy link
Member

@ademidoff ademidoff commented Nov 3, 2023 •
edited
Loading

PMM-12529

Link to the Feature Build: SUBMODULES-3472

@ademidoff ademidoff changed the base branch from main to v3 November 3, 2023 13:46
@codecov Codecov
Copy link

codecov bot commented Nov 3, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3@834bfa8). Click here to learn what that means.

Additional details and impacted files 
@@          Coverage Diff          @@
##             v3    #2590   +/-   ##
=====================================
  Coverage      ?   44.01%           
=====================================
  Files         ?      358           
  Lines         ?    42074           
  Branches      ?        0           
=====================================
  Hits          ?    18517           
  Misses        ?    21960           
  Partials      ?     1597
Flag Coverage Δ
admin 10.43% <0.00%> (?)
vmproxy 68.57% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ademidoff ademidoff marked this pull request as ready for review November 3, 2023 14:38
@ademidoff ademidoff requested a review from a team as a code owner November 3, 2023 14:38
@ademidoff ademidoff requested review from idoqo, artemgavrilov, BupycHuk, EvgeniyPatlan and talhabinrizwan and removed request for a team and EvgeniyPatlan November 3, 2023 14:38
artemgavrilov
artemgavrilov approved these changes Nov 3, 2023
View reviewed changes
managed/models/postgresql_version_test.go Outdated Show resolved Hide resolved
BupycHuk
BupycHuk reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we need to make pmm2-client to be installed under pmm user for all installation. isn't it possible to do only for PMM Server?

@ademidoff
Copy link
Member Author

Not sure if we need to make pmm2-client to be installed under pmm user for all installation. isn't it possible to do only for PMM Server?

Maybe we can. Let me try :)

@ademidoff ademidoff mentioned this pull request Nov 19, 2023
Closed
@ademidoff ademidoff requested a review from a team as a code owner November 20, 2023 15:01
BupycHuk
BupycHuk approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@BupycHuk BupycHuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix merge conflicts

This was referenced Nov 30, 2023
Closed
Closed
@ademidoff ademidoff merged commit 9b44bbb into v3 Nov 30, 2023
28 of 29 checks passed
@ademidoff ademidoff deleted the PMM-12529-run-pmm-agent-as-non-root branch November 30, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemgavrilov artemgavrilov artemgavrilov approved these changes

@BupycHuk BupycHuk BupycHuk approved these changes

@idoqo idoqo Awaiting requested review from idoqo idoqo is a code owner automatically assigned from percona/pmm-review-be

@talhabinrizwan talhabinrizwan Awaiting requested review from talhabinrizwan talhabinrizwan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ademidoff @BupycHuk @artemgavrilov