PMM-12529 run pmm-agent as non-root #2585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2585 +/- ##
==========================================
+ Coverage 41.99% 42.75% +0.76%
==========================================
Files 391 391
Lines 49099 49099
==========================================
+ Hits 20619 20994 +375
+ Misses 26540 26131 -409
- Partials 1940 1974 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ademidoff
requested review from
idoqo and
artemgavrilov
and removed request for
a team
ademidoff
commented
Oct 31, 2023
| @@ -100,10 +100,10 @@ | |||
| non_unique: true | |||
| loop: | |||
| - { name: pmm, gid: 1000 } | |||
| - { name: pmm-agent, gid: 1001 } | |||
There was a problem hiding this comment.
This was a dirty hack a year ago, which resulted in non-unique group and user ids.
In particular, pmm-agent overlaps with ssh_keys in RHEL9:
[root@pmm-server pmm] # ls -la /usr/local/percona/pmm2
total 48
drwxr-xr-x 1 pmm-agent ssh_keys 4096 Oct 31 08:40 .
drwxr-xr-x 1 pmm-agent ssh_keys 4096 Oct 31 08:37 ..
drwxr-xr-x 2 pmm-agent ssh_keys 4096 Oct 31 08:37 bin
drwxr-xr-x 1 pmm-agent ssh_keys 4096 Oct 31 08:38 cache
drwxr-xr-x 4 pmm-agent ssh_keys 4096 Oct 31 08:37 collectors
drwxr-xr-x 1 pmm-agent ssh_keys 4096 Oct 31 09:39 config
drwxr-xr-x 2 pmm-agent ssh_keys 4096 Oct 31 08:37 exporters
drwx------ 1 pmm-agent ssh-keys 4096 Oct 31 09:43 tmp
drwxr-xr-x 2 pmm-agent ssh_keys 4096 Oct 31 08:37 toolsI believe we'd better change it so it doesn't come in conflict with the existing groups.
JiriCtvrtka
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12529
Link to the Feature Build: SUBMODULES-3431
Note: this change works well in PMM v2, let's see if we can merge it there. Maybe there is no reason to wait for v3.