PMM-12422 restrict agent interface

[idoqo]

PMM-12422

Link to the Feature Build: SUBMODULES-3420

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

• API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

• Links to related pull requests (optional).

[codecov]

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (6c37873) 42.73% compared to head (612be35) 42.76%.

Files	Patch %	Lines
managed/services/agents/state.go	0.00%	5 Missing ⚠️
admin/commands/management/add_postgresql.go	0.00%	4 Missing ⚠️
admin/commands/management/add_mongodb.go	0.00%	2 Missing ⚠️
admin/commands/management/add_proxysql.go	0.00%	2 Missing ⚠️
...in/commands/inventory/add_agent_mysqld_exporter.go	0.00%	1 Missing ⚠️
...dmin/commands/inventory/add_agent_node_exporter.go	0.00%	1 Missing ⚠️
.../commands/inventory/add_agent_postgres_exporter.go	0.00%	1 Missing ⚠️
.../commands/inventory/add_agent_proxysql_exporter.go	0.00%	1 Missing ⚠️
admin/commands/management/add_mysql.go	0.00%	1 Missing ⚠️
agent/commands/clients.go	0.00%	1 Missing ⚠️
... and 6 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2534      +/-   ##
==========================================
+ Coverage   42.73%   42.76%   +0.02%     
==========================================
  Files         391      391              
  Lines       49241    49282      +41     
==========================================
+ Hits        21043    21074      +31     
- Misses      26218    26227       +9     
- Partials     1980     1981       +1     

Flag	Coverage Δ
admin	10.47% <0.00%> (+0.02%)	⬆️
agent	53.47% <66.66%> (+<0.01%)	⬆️
managed	43.52% <80.00%> (+0.03%)	⬆️
vmproxy	68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[BupycHuk]

we need to implement this flag for inventory commands and flags as well.
Regarding variable name maybe it's better to keep it shorter like --expose-exporter?

[ademidoff]

we need to implement this flag for inventory commands and flags as well. Regarding variable name maybe it's better to keep it shorter like --expose-exporter?

An even better term would use the verb bind, which seems to be heavily used in such cases. I guess something like --bind-all-interfaces or --bind-all would sound reasonable and more semantic.

[idoqo]

we need to implement this flag for inventory commands and flags as well. Regarding variable name maybe it's better to keep it shorter like --expose-exporter?

An even better term would use the verb bind.

I went with this initially too, but then felt like we may want to have "exporter" somewhere in the flag to reflect the fact that only exporters will be affected.

[BupycHuk]

it can be --bind-exporter with two options all and local

[BupycHuk]

I believe there should be better wording for the description. Maybe expose exporter APIs to the world