Skip to content

Commit

Permalink
PMM-12913 refactor /v1/management/agent/List
Browse files Browse the repository at this point in the history
  • Loading branch information
ademidoff committed Apr 10, 2024
1 parent a6f6d68 commit e1f0044
Show file tree
Hide file tree
Showing 36 changed files with 1,996 additions and 2,245 deletions.
2 changes: 0 additions & 2 deletions Makefile.include
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ gen-api: ## Generate PMM API
api/user/v1/json/v1.json \
api/inventory/v1/json/v1.json \
api/management/v1/json/v1.json \
api/management/v1/service/json/service.json \
api/actions/v1/json/v1.json \
api/alerting/v1/json/v1.json \
api/advisors/v1/json/v1.json \
Expand Down Expand Up @@ -148,7 +147,6 @@ clean: clean_swagger ## Remove generated files
api/user/v1 \
api/inventory/v1 \
api/management/v1 \
api/management/v1/service \
api/actions/v1 \
api/alerting/v1 \
api/advisors/v1 \
Expand Down
15 changes: 8 additions & 7 deletions api/MIGRATION_TO_V3.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ POST /v1/inventory/Services/CustomLabels/Remove PUT /v1/inventory/services/{

**ManagementService** **ManagementService**
POST /v1/management/Annotations/Add POST /v1/management/annotations ✅
POST /v1/management/Agent/List GET /v1/management/agents ✅ Moved from MgmtService
POST /v1/management/Node/Register POST /v1/management/nodes ✅
POST /v1/management/Node/Unregister DELETE /v1/management/nodes/{node_id} ✅ ?force=true
POST /v1/management/Node/Get GET /v1/management/nodes/{node_id} ✅ Moved from MgmtService
Expand All @@ -64,13 +65,13 @@ POST /v1/management/AzureDatabase/Discover POST /v1/management/services
POST /v1/management/RDS/Discover POST /v1/management/services:discoverRDS
POST /v1/management/Service/Remove DELETE /v1/management/services/{service_id} ✅ NOTE: in addition, it accepts ?service_type=

**MgmtService** **ManagementV1Beta1Service** NOTE: promote to v1 from v1beta1
POST /v1/management/Agent/List GET /v1/management/agents
POST /v1/management/Node/Get GET /v1/management/nodes/{node_id} ✅
POST /v1/management/Node/List GET /v1/management/nodes ✅
POST /v1/management/AzureDatabase/Add POST /v1/management/services ✅
POST /v1/management/AzureDatabase/Discover POST /v1/management/services:discoverAzure
POST /v1/management/Service/List GET /v1/management/services ✅
**MgmtService** **MgmtService** NOTE: promoted to v1 from v1beta1
POST /v1/management/Agent/List GET /v1/management/agents ✅ Moved to ManagementService
POST /v1/management/Node/Get GET /v1/management/nodes/{node_id} ✅ Moved to ManagementService
POST /v1/management/Node/List GET /v1/management/nodes ✅ Moved to ManagementService
POST /v1/management/AzureDatabase/Add POST /v1/management/services ✅ Moved to ManagementService
POST /v1/management/AzureDatabase/Discover POST /v1/management/services:discoverAzure Moved to ManagementService
POST /v1/management/Service/List GET /v1/management/services ✅ Moved to ManagementService

**ActionsService** **ActionService**
POST /v1/actions/Cancel POST /v1/actions:cancelAction
Expand Down
2 changes: 0 additions & 2 deletions api/buf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,6 @@ lint:
- agent/v1/agent.proto # We want our naming in this file to be different
RPC_RESPONSE_STANDARD_NAME:
- agent/v1/agent.proto # We want our naming in this file to be different
PACKAGE_DIRECTORY_MATCH: # Address these warnings during API restructuring
- management/v1/service/service.proto
PACKAGE_VERSION_SUFFIX:
- common/common.proto # We don't want to version this file

Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit e1f0044

Please sign in to comment.