Merge branch 'v3' into Remove_duplicate_privileges

.github/workflows/main.yml

@@ -138,8 +138,21 @@ jobs:
           go env | sort
           git status
 
+
+  typos_check:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          fetch-depth: 0
+      - name: Check spelling of md files
+        uses: crate-ci/typos@9d890159570d5018df91fedfa40b4730cd4a81b1 # v1.28.4
+        with:
+          files: "**/*.md ./documentation/**/*.md"
+
   merge-gatekeeper:
-    needs: [ check ]
+    needs: [ check, typos_check ]
     name: Merge Gatekeeper
     if: ${{ always() }}
     runs-on: ubuntu-22.04

.gitignore

@@ -19,9 +19,6 @@ agent/agents/mysql/slowlog/parser/crashers/
 agent/agents/mysql/slowlog/parser/suppressions/
 agent/agents/mysql/slowlog/parser/parser-fuzz.zip
 
-update/*.runcover.out
-update/*.test
-
 fuzzing/
 *-fuzz.zip
 *.bench

.typos.toml

@@ -0,0 +1,6 @@
+[default]
+extend-ignore-identifiers-re = [
+    "LKE",
+    "ue",
+    "ba"
+]

CONTRIBUTING.md

@@ -26,7 +26,6 @@ This project is built from several repositories:
 
 * [percona/pmm-managed](https://github.com/percona/pmm/tree/main/managed) manages configuration of PMM server components (VictoriaMetrics, Grafana, etc.) and exposes API for that. APIs are used by [pmm-admin](https://github.com/percona/pmm/tree/main/admin)
 * [percona/qan-api](https://github.com/percona/pmm/tree/main/qan-api2) query analytics API
-* [percona/pmm-update](https://github.com/percona/pmm/tree/main/update) is a tool for updating packages and OS configuration for PMM
 
 #### Frontends
 
@@ -127,7 +126,7 @@ Since PMM has a lot of components, we will mention only three big parts of it.
   * This command will register local pmm-agent to PMM Server and generate config file `pmm-agent-dev.yaml`
 * Once it's connected just use `make run` to run pmm-agent.
 * To work correctly, pmm-agent needs vmagent and exporters installed on the system.
-  * The first option is to install pmm-client using this instrucion https://docs.percona.com/percona-monitoring-and-management/setting-up/client/index.html#install. It will install all exporters as well.
+  * The first option is to install pmm-client using this instruction https://docs.percona.com/percona-monitoring-and-management/setting-up/client/index.html#install. It will install all exporters as well.
   * Another option is to do it manually
     * vmagent and exporters can be installed by building each of them or by downloading the pmm-client tarball from [percona.com](https://www.percona.com/downloads/pmm2/) and copying binaries to the exporters_base directory configured in `pmm-agent-dev.yaml` file.
     * All paths to exporter binaries are configured in `pmm-agent-dev.yaml`, so they can be changed manually if necessary.

README.md

@@ -34,7 +34,7 @@ See the [PMM Documentation](https://www.percona.com/doc/percona-monitoring-and-m
 
 Please check our [Documentation](https://docs.percona.com/percona-monitoring-and-management/details/architecture.html) for the actual architecture.
 
-![Overal Architecture](https://docs.percona.com/percona-monitoring-and-management/_images/C_S_Architecture.jpg "Client Server Architecture")
+![Overall Architecture](https://docs.percona.com/percona-monitoring-and-management/_images/C_S_Architecture.jpg "Client Server Architecture")
 
 
 ![PMM Server](https://docs.percona.com/percona-monitoring-and-management/_images/PMM-Server-Component-Based-View.jpg 'PMM Server Architecture')

api-tests/server/logs_test.go

@@ -56,9 +56,9 @@ func TestDownloadLogs(t *testing.T) {
 		"nginx.log",
 		"pmm-agent.log",
 		"pmm-agent.yaml",
+		"pmm-init.log",
 		"pmm-managed.log",
 		"pmm-ssl.conf",
-		"pmm-update-perform-init.log",
 		"pmm-version.txt",
 		"pmm.conf",
 		"pmm.ini",

api/MIGRATION_TO_V3.md

@@ -174,7 +174,7 @@
   POST /v1/management/Role/SetDefault                          POST /v1/accesscontrol/roles:setDefault            ✅
   POST /v1/management/Role/Update                              PUT /v1/accesscontrol/roles/{role_id}              ✅
 
-  **Management:: Intergrated Alerting**
+  **Management:: Integrated Alerting**
   POST /v1/management/ia/Alerts/List                           N/A                                                ❌ Deprecated in v2 and removed in v3
   POST /v1/management/ia/Alerts/Toggle                         N/A                                                ❌ Deprecated in v2 and removed in v3
   POST /v1/management/ia/Channels/Add                          N/A                                                ❌ Deprecated in v2 and removed in v3

build/ansible/pmm-docker/init.yml

@@ -1,5 +1,5 @@
 ---
-# This playbook gets executed by pmm-update-perform-init
+# This playbook is run by the `pmm-init` supervisord process
 - hosts: all
   become: true
   become_method: su

build/ansible/roles/pmm-images/tasks/main.yml

@@ -92,7 +92,6 @@
       - percona-qan-api2
       - percona-dashboards
       - pmm-managed
-      - pmm-update
       - pmm-dump
       - vmproxy
     state: installed
@@ -150,10 +149,10 @@
   register: managed_init_result
   changed_when: True
 
-- name: Disable pmm-update-perform-init
+- name: Disable pmm-init
   ini_file:
     path: /etc/supervisord.d/pmm.ini
-    section: program:pmm-update-perform-init
+    section: program:pmm-init
     option: autostart
     value: "false"
 

build/ansible/roles/supervisord/files/pmm.ini

@@ -8,8 +8,8 @@ username = dummy
 password = dummy
 
 ; we rewrite autostart to true during update or build.
-[program:pmm-update-perform-init]
-command = /usr/sbin/pmm-update -run-playbook -playbook=/opt/ansible/pmm-docker/init.yml
+[program:pmm-init]
+command = /usr/bin/ansible-playbook /opt/ansible/pmm-docker/init.yml
 user = pmm
 directory = /
 autorestart = unexpected
@@ -20,8 +20,8 @@ startretries = 3
 startsecs = 1
 stopsignal = TERM
 stopwaitsecs = 300
-stdout_logfile = /srv/logs/pmm-update-perform-init.log
-stdout_logfile_maxbytes = 50MB
+stdout_logfile = /srv/logs/pmm-init.log
+stdout_logfile_maxbytes = 20MB
 stdout_logfile_backups = 3
 redirect_stderr = true