-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PG-1241 Documented KMIP integration and setup #368
Conversation
Performance test results:
|
modified: documentation/docs/_images/tde-flow.png modified: documentation/docs/setup.md modified: documentation/docs/tde.md
763088c
to
aaf93e3
Compare
8211309
to
4bcae30
Compare
documentation/docs/tde.md
Outdated
@@ -6,7 +6,7 @@ Transparent Data Encryption is a technology to protect data at rest. The encrypt | |||
|
|||
To encrypt the data, two types of keys are used: | |||
|
|||
* Database keys to encrypt user data. These are stored internally, near the data that they encrypt. | |||
* Table encryption keys (TEK) to encrypt user data. These keys are stored internally, near the data that they encrypt. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this acronym? We never used that before (TEK).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been used in Jan's talks. But TBH I like database keys more)
Changing back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are incorrect. we are simply calling them internal keys in the code, because that's what they are.
These can encrypt in theory any database file - tables, indexes, WAl, who knows what in the future...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
documentation/docs/setup.md
Outdated
@@ -58,12 +58,14 @@ Load the `pg_tde` at the start time. The extension requires additional shared me | |||
|
|||
* `provider-name` is the name of the provider. You can specify any name, it's for you to identify the provider. | |||
* `kmip-IP` is the IP address of a domain name of the KMIP server | |||
* The port to communicate with the KMIP server. The default port is `5696`. | |||
* `5696` is the port to communicate with the KMIP server. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
port
is the port to communicate with the KMIP server? It can be anything, depending on the KMIP server, 5696 is just the official port mot servers use...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is hardcoded now? So not a default one, but required one, correct? Why does the current wording not suit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is a parameter the user has to specify.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
Description
Documented KMIP integration and setup
modified: documentation/docs/_images/tde-flow.png
modified: documentation/docs/setup.md
modified: documentation/docs/tde.md