Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPSMDB-1248 Add wait_for_running check after cluster creation in self-healing-chaos tests #1775

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

ptankov
Copy link
Contributor

@ptankov ptankov commented Jan 7, 2025

K8SPSMDB-1248 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Test case wait_for_running fails on Minikube just before enable backups and the cluster ends up in "error" state.

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
I thought that we shouldn't care whether the cluster is ready or not and it's Kubernetes' duty to queue my requests and apply them when the right time comes. However, Kubernetes itself does not enforce application-specific logic. We should allow the initialization process to complete, ensuring the core components (e.g., the replica set, storage volumes) are fully operational and then enable backups. Adding wait_for_running before doing anything else just like in every test case.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?
  • Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported MongoDB version?
  • Does the change support oldest and newest supported Kubernetes version?

@pull-request-size pull-request-size bot added the size/XS 0-9 lines label Jan 7, 2025
@ptankov ptankov changed the title Add wait for running check after cluster creation in self-healing chaos tests K8SPSMDB-1248 Add wait for running check after cluster creation in self-healing chaos tests Jan 7, 2025
@ptankov ptankov changed the title K8SPSMDB-1248 Add wait for running check after cluster creation in self-healing chaos tests K8SPSMDB-1248 Add wait_for_running check after cluster creation in self-healing chaos tests Jan 7, 2025
@ptankov ptankov changed the title K8SPSMDB-1248 Add wait_for_running check after cluster creation in self-healing chaos tests K8SPSMDB-1248 Add wait_for_running check after cluster creation in self-healing_chaos tests Jan 7, 2025
@ptankov ptankov requested a review from egegunes January 8, 2025 09:25
@ptankov ptankov changed the title K8SPSMDB-1248 Add wait_for_running check after cluster creation in self-healing_chaos tests K8SPSMDB-1248 Add wait_for_running check after cluster creation in self-healing-chaos tests Jan 8, 2025
@JNKPercona
Copy link
Collaborator

Test name Status
arbiter passed
balancer passed
custom-replset-name passed
custom-tls passed
custom-users-roles passed
custom-users-roles-sharded passed
cross-site-sharded passed
data-at-rest-encryption passed
data-sharded passed
demand-backup passed
demand-backup-fs passed
demand-backup-eks-credentials-irsa passed
demand-backup-physical passed
demand-backup-physical-sharded passed
demand-backup-sharded passed
expose-sharded passed
ignore-labels-annotations passed
init-deploy passed
finalizer passed
ldap passed
ldap-tls passed
limits passed
liveness passed
mongod-major-upgrade passed
mongod-major-upgrade-sharded passed
monitoring-2-0 passed
multi-cluster-service passed
non-voting passed
one-pod passed
operator-self-healing-chaos passed
pitr passed
pitr-sharded passed
pitr-physical passed
pvc-resize passed
recover-no-primary passed
replset-overrides passed
rs-shard-migration passed
scaling passed
scheduled-backup passed
security-context passed
self-healing-chaos passed
service-per-pod passed
serviceless-external-nodes passed
smart-update passed
split-horizon passed
stable-resource-version passed
storage passed
tls-issue-cert-manager passed
upgrade passed
upgrade-consistency passed
upgrade-consistency-sharded-tls passed
upgrade-sharded passed
users passed
version-service passed
We run 54 out of 54

commit: 35b1c12
image: perconalab/percona-server-mongodb-operator:PR-1775-35b1c129

@ptankov ptankov merged commit 44123aa into main Jan 8, 2025
17 checks passed
@ptankov ptankov deleted the K8SPSMDB-1248 branch January 8, 2025 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS 0-9 lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants