-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow remote schemas. Fix #160 #162
Conversation
Do you have an ETA on ubiquerg 0.8.0? Sometime in the next week? |
can be anytime. you can release it if it helps you. I don't have anything immediately planned to add to it. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #162 +/- ##
==========================================
+ Coverage 54.50% 55.12% +0.61%
==========================================
Files 15 15
Lines 2341 2324 -17
==========================================
+ Hits 1276 1281 +5
+ Misses 1065 1043 -22 ☔ View full report in Codecov by Sentry. |
|
I've also refactored read_yaml_data with yacman.load_yaml. I will go ahead and merge these changes to dev, adding the action item to update the documentation to the original issue in #160 |
This allows the schemas to be remote. I did this by using
yacman.load_yaml
, instead of an internalread_yaml_data
which did not handle URLs. I also replaced an internalmk_abs_via_cfg
function call withubiquerg.mkabs
--mk_abs_via_cfg
use bymkabs
, and then remove that function?read_yaml_data
with theyacman.load_yaml
? This would require a bit of refactoring because the internalread_yaml_data
was not just reading yaml, but was used for a few other things as well. In general I don't like that entanglement, and it would reduce maintenance to just useyacman.load_yaml
.One nice thing about this is that it will make it so much easier to get started using pipestat. Our tutorials can just gloss over the schema complexity and point to some general-purposes, training schemas, so then the user doesn't have to create one locally to just get started quickly.
TODO: