do not fail on "has" when autowiring is disabled

peoplepath · Jun 6, 2019 · ba7371b · ba7371b
1 parent 462c702
commit ba7371b
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/ServiceContainer.php b/src/ServiceContainer.php
@@ -86,6 +86,11 @@ public function get($id) {
      * @return bool
      */
     public function has($id): bool {
+        // do not attempt create a service when "autowire" is disabled
+        if (!$this->autowireEnabled) {
+            return isset($this->instances[$id]);
+        }
+
         try {
             $this->get($id); // attempt create a service
         } catch (ServiceNotFoundException $e) {

diff --git a/tests/ServiceContainerTest.php b/tests/ServiceContainerTest.php
@@ -266,6 +266,12 @@ function testProperFailWhenFactoryIsDefinedBadly() {
         $this->expectExceptionMessage('Empty result from factory, id: Poo');
         $container->make('Poo');
     }
+
+    function testHasMethodReturnsFalseNotAnExceptionIfAutowiringIsDisabled() {
+        $container = new ServiceContainer(['autowire' => false]);
+
+        $this->assertFalse($container->has(Foo::class));
+    }
 }
 
 interface CacheAdapterInterface {}