work with multiple tag types

peoplepath · Sep 16, 2024 · 12fb568 · 12fb568
1 parent d7088a0
commit 12fb568
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/Fixtures.php b/src/Fixtures.php
@@ -27,7 +27,7 @@ public function mergeWith(Fixtures $fixtures) : Fixtures {
         return new Fixtures(
             $this->label,
             in_array('write', [$fixtures->mode, $this->mode]) ? 'write' : 'read-only',
-            array_values(array_unique(array_merge($fixtures->files, $this->files))),
+            ...array_values(array_unique(array_merge($fixtures->files, $this->files))),
         );
     }
 }
diff --git a/src/FixturesAnnotationToAttributeRector.php b/src/FixturesAnnotationToAttributeRector.php
@@ -94,15 +94,19 @@ public function refactor(Node $node): ?Node
 
         foreach ($phpDocInfo->getTagsByName('fixtures') as $fixturesPhpDocTagNode) {
             /** @var PhpDocTagNode $fixturesPhpDocTagNode */
-            if (!$fixturesPhpDocTagNode->value instanceof DoctrineAnnotationTagValueNode) {
-                continue; // no value
+
+            // extract attribute params configuration
+            if ($fixturesPhpDocTagNode->value instanceof DoctrineAnnotationTagValueNode) {
+                $fixtures = explode(' ', $fixturesPhpDocTagNode->value->getAttribute('attribute_comment'));
+            } elseif ($fixturesPhpDocTagNode->value instanceof \PHPStan\PhpDocParser\Ast\PhpDoc\GenericTagValueNode) {
+                $fixtures = explode(' ', $fixturesPhpDocTagNode->value->value);
+            } else {
+                continue;
             }
 
             // test from doc blocks
             $this->phpDocTagRemover->removeTagValueFromNode($phpDocInfo, $fixturesPhpDocTagNode);
 
-            // extract attribute params configuration
-            $fixtures = explode(' ', $fixturesPhpDocTagNode->value->getAttribute('attribute_comment'));
 
             $attributeGroups[] = $this->phpAttributeGroupFactory
                 ->createFromClassWithItems(Fixtures::class, [$fixtures]);