Skip to content

Updating to Remix v2 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updating to Remix v2 #173

wants to merge 3 commits into from

Conversation

rissois
Copy link

@rissois rissois commented Jul 12, 2024

Trying to make RemixGCF compatible with Remix V2.

I'm a little out of my element here, so this PR is untested and should not be merged. I wanted to get the ball rolling and see if anyone can help me out with one snag in the return headers line of createRemixHeaders:

Type 'import("/Users/XXX/Desktop/remix-google-cloud-functions/node_modules/undici-types/fetch").Headers' is not assignable to type 'Headers'.
  The types returned by '[Symbol.iterator]()' are incompatible between these types.
    Property '[Symbol.iterator]' is missing in type 'SpecIterator<[string, string], any, undefined>' but required in type 'IterableIterator<[string, string]>'.ts(2322)
lib.es2015.iterable.d.ts(53, 5): '[Symbol.iterator]' is declared here.

I could roll down the Remix to v2.8.1, which is prior to the introduction of undici, unless someone can explain how to fix this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant