-
Notifications
You must be signed in to change notification settings - Fork 730
[BACKLOG-46631] Ensured that the list of plugin directories is sorted #6045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements sorted processing of plugin directories to ensure consistent behavior and prevent duplicate plugin loading. The main goal is to process plugin folders with datestamps after those without, while adding safeguards against duplicate plugin IDs.
- Sorts plugin directories before processing to handle datestamped folders consistently
- Adds duplicate plugin ID detection to prevent loading plugins with the same ID
- Enhanced logging for better debugging and monitoring of plugin processing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
File | Description |
---|---|
SystemPathXmlPluginProvider.java | Implements directory sorting, duplicate plugin detection, and enhanced logging |
SystemPathXmlPluginProviderTest.java | Adds test coverage for duplicate plugin ID handling scenario |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...rc/main/java/org/pentaho/platform/plugin/services/pluginmgr/SystemPathXmlPluginProvider.java
Show resolved
Hide resolved
...rc/main/java/org/pentaho/platform/plugin/services/pluginmgr/SystemPathXmlPluginProvider.java
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
7f9fe81
to
e917f14
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
before processing to ensure consistent behavior and that plugin folders with datestamps in the name (new plugin installs/updates) will be processed after those without (previous installs to be deleted). Also added an extra check after processing the plugin folder to ensure a plugin with the same ID hasn't already been processed. The second check should not be necessary after sorting the folder names, but this will prevent duplicate plugins from loading.
e917f14
to
3c734c9
Compare
Analysis Details0 IssuesCoverage and DuplicationsProject ID: pentaho:pentaho-platform-ce-parent |
Note:Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system. |
✅ Build finished in 24m 16sBuild command: mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl extensions 👌 All tests passed! Tests run: 1736, Failures: 0, Skipped: 1 Test Results ℹ️ This is an automatic message |
before processing to ensure consistent behavior and that plugin folders with datestamps in the name (new plugin installs/updates) will be processed after those without (previous installs to be deleted). Also added an extra check after processing the plugin folder to ensure a plugin with the same ID hasn't already been processed. The second check should not be necessary after sorting the folder names, but this will prevent duplicate plugins from loading.