Skip to content

Conversation

peterrinehart
Copy link
Contributor

before processing to ensure consistent behavior and that plugin folders with datestamps in the name (new plugin installs/updates) will be processed after those without (previous installs to be deleted). Also added an extra check after processing the plugin folder to ensure a plugin with the same ID hasn't already been processed. The second check should not be necessary after sorting the folder names, but this will prevent duplicate plugins from loading.

@peterrinehart peterrinehart requested a review from a team as a code owner October 13, 2025 19:36
@peterrinehart peterrinehart requested a review from Copilot October 13, 2025 19:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements sorted processing of plugin directories to ensure consistent behavior and prevent duplicate plugin loading. The main goal is to process plugin folders with datestamps after those without, while adding safeguards against duplicate plugin IDs.

  • Sorts plugin directories before processing to handle datestamped folders consistently
  • Adds duplicate plugin ID detection to prevent loading plugins with the same ID
  • Enhanced logging for better debugging and monitoring of plugin processing

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
SystemPathXmlPluginProvider.java Implements directory sorting, duplicate plugin detection, and enhanced logging
SystemPathXmlPluginProviderTest.java Adds test coverage for duplicate plugin ID handling scenario

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@peterrinehart peterrinehart marked this pull request as draft October 13, 2025 19:49

This comment has been minimized.

@buildguy

This comment has been minimized.

This comment has been minimized.

@buildguy

This comment has been minimized.

before processing to ensure consistent behavior and that plugin folders
with datestamps in the name (new plugin installs/updates) will be
processed after those without (previous installs to be deleted). Also
added an extra check after processing the plugin folder to ensure a
plugin with the same ID hasn't already been processed. The second check
should not be necessary after sorting the folder names, but this will
prevent duplicate plugins from loading.
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 95.00% Coverage (35.00% Estimated after merge)
  • Duplications 0.00% Duplicated Code (3.10% Estimated after merge)

Project ID: pentaho:pentaho-platform-ce-parent

View in SonarQube

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

✅ Build finished in 24m 16s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox -pl extensions

👌 All tests passed!

Tests run: 1736, Failures: 0, Skipped: 1    Test Results


ℹ️ This is an automatic message

@peterrinehart peterrinehart marked this pull request as ready for review October 14, 2025 16:22
@pentaho-whartman pentaho-whartman merged commit c13b9bd into pentaho:master Oct 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants