Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove neethi jar runtime dependency #5797

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NJtwentyone
Copy link
Contributor

@NJtwentyone NJtwentyone commented Nov 26, 2024

slack conversation: https://hitachivantara-eng.slack.com/archives/C0819BSJK/p1732646272808169

- group changed from 'org.apache.ws.commons.neethi:neethi' to 'org.apache:neethi' back in 2007
- v2.0.1 does not have published pom.xml, caused IDE build issues, v2.0.2 and above does have pom.xml
- only artifact that uses neethi is axis2-kernel-1.5.jar
- PPP-4174 removed all axis2 jars from report-designer including axis2-kernel-1.5.jar
@NJtwentyone NJtwentyone requested a review from a team as a code owner November 26, 2024 17:11
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

✅ Build finished in 41m 51s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox

👌 All tests passed!

Tests run: 2724, Failures: 0, Skipped: 5    Test Results


ℹ️ This is an automatic message

@NJtwentyone
Copy link
Contributor Author

conversation about removal was started on slack: https://hitachivantara-eng.slack.com/archives/C0819BSJK/p1732646272808169

@NJtwentyone NJtwentyone marked this pull request as ready for review November 27, 2024 15:56
@NJtwentyone NJtwentyone marked this pull request as draft December 6, 2024 15:35
@NJtwentyone
Copy link
Contributor Author

waiting until after 10.2 LTS is finalized to merge into master 10.3, it this doesn't get backported and possibly cause any negative effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants