Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PPP-5411] [PPP-5420] Update Pentaho User Console community release h… #5794

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

singletonc
Copy link
Contributor

…elp about page to display enterprise license text and perform limited smoke test

  • Limit to one LICENSE.TXT file at the root of the project
  • Copy license text file to root of product artifact as well as GWT accessible location
  • No additional error handling, if license text is missing in @source annotation, the project will not compile, it will tell you the file is missing
  • AboutCommand now gets the license text from HTTP request to the server instead of compiling it into GWT, this way it can be easily overridden in EE
  • Chained version and license request callbacks while caching the results to prevent additional calls

…elp about page to display enterprise license text and perform limited smoke test

- Limit to one LICENSE.TXT file at the root of the project
- Copy license text file to root of product artifact as well as GWT accessible location
- No additional error handling, if license text is missing in @source annotation, the project will not compile, it will tell you the file is missing
- AboutCommand now gets the license text from HTTP request to the server instead of compiling it into GWT, this way it can be easily overridden in EE
- Chained version and license request callbacks while caching the results to prevent additional calls
@singletonc singletonc requested a review from a team as a code owner November 22, 2024 17:06
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube

Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@buildguy
Copy link
Collaborator

👍 Frogbot scanned this pull request and did not find any new security issues.

Note:

Frogbot also supports Contextual Analysis, Secret Detection, IaC and SAST Vulnerabilities Scanning. This features are included as part of the JFrog Advanced Security package, which isn't enabled on your system.


@buildguy
Copy link
Collaborator

✅ Build finished in 38m 21s

Build command:

mvn clean verify -B -e -Daudit -Djs.no.sandbox

👌 All tests passed!

Tests run: 2724, Failures: 0, Skipped: 5    Test Results


ℹ️ This is an automatic message

@rmansoor rmansoor merged commit 90632bf into pentaho:master Dec 3, 2024
7 of 8 checks passed
singletonc pushed a commit to singletonc/pentaho-platform that referenced this pull request Dec 6, 2024
Merge pull request pentaho#5794 from singletonc/PPP-5420

[PPP-5411] [PPP-5420] Update Pentaho User Console community release h…

(cherry picked from commit 90632bf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants