[BACKLOG-43059] - Kettle changes for DB Connections #9779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sVarma1992
approved these changes
Jan 21, 2025
sVarma1992
reviewed
Jan 21, 2025
| Method actionMethod = DatabaseLookup.class.getDeclaredMethod(fieldName + "Action", Map.class); | ||
| this.setStepMetaInterface(stepMetaInterface); | ||
| response = (JSONObject) actionMethod.invoke(this, queryParamToValues); | ||
| } catch (NoSuchMethodException e) { |
There was a problem hiding this comment.
checkstyle is not followed please take care of it
sVarma1992
reviewed
Jan 21, 2025
| response = (JSONObject) actionMethod.invoke(this, queryParamToValues); | ||
| } catch (NoSuchMethodException e) { | ||
| log.logError("Method not found: " + e.getMessage(), e); | ||
| response.put("actionStatus", "FAILURE"); |
There was a problem hiding this comment.
why are the values "Failure" etc are hard coded, please use the ones present in step Interface as used by other steps
sVarma1992
reviewed
Jan 21, 2025
| } | ||
|
|
||
| @SuppressWarnings("java:S1144") // Using reflection this method is being invoked | ||
| private JSONObject getTableFieldAction(Map<String, String> queryParams) { |
There was a problem hiding this comment.
Does the same code is present in dialog as well? If so then we have to refactor the dialog code for maintainability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.