fix(new-render): fix composition texts spec files#455
Draft
daniel-herrero wants to merge 1 commit intoepic/new-renderfrom
Draft
fix(new-render): fix composition texts spec files#455daniel-herrero wants to merge 1 commit intoepic/new-renderfrom
daniel-herrero wants to merge 1 commit intoepic/new-renderfrom
Conversation
daniel-herrero
force-pushed
the
dherrero/task/new-render-fix-composition-text
branch
2 times, most recently
from
2e9fc9a to
2c147ff
Compare
daniel-herrero
force-pushed
the
dherrero/task/new-render-fix-composition-text
branch
from
2c147ff to
55129f1
Compare
daniel-herrero
force-pushed
the
dherrero/task/new-render-fix-composition-text
branch
from
55129f1 to
7e82877
Compare
daniel-herrero
force-pushed
the
dherrero/task/new-render-fix-composition-text
branch
from
7e82877 to
385028d
Compare
daniel-herrero
force-pushed
the
dherrero/task/new-render-fix-composition-text
branch
from
385028d to
6b7b103
Compare
daniel-herrero
force-pushed
the
dherrero/task/new-render-fix-composition-text
branch
from
6b7b103 to
965376e
Compare
daniel-herrero
force-pushed
the
dherrero/task/new-render-fix-composition-text
branch
from
965376e to
b2439a6
Compare
daniel-herrero
commented
Mar 10, 2026
| await designPanelPage.changeWidthForLayer('200'); | ||
| await mainPage.waitForChangeIsUnsaved(); | ||
| await mainPage.waitForChangeIsSaved(); | ||
| await designPanelPage.changeHeightForLayer('200'); |
Collaborator
Author
There was a problem hiding this comment.
The screenshot is failing because the height doesn't change to 200px at a unique attempt (possibly related to this issue)
daniel-herrero
commented
Mar 10, 2026
| await mainPage.waitForResizeHandlerVisible(); | ||
| await mainPage.focusLayerViaShortcut(); | ||
| await expect(mainPage.viewport).toHaveScreenshot( | ||
| 'text-stroke-inside-dotted.png', |
Collaborator
Author
There was a problem hiding this comment.
Depending on this issue, the screenshot will be regenerated (accepting the new behavior) or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done Definition Checks
Taiga URL (optional)
If relevant, include the Taiga URL
Taiga Ticket: NUMBER
Description
This PR resolves ...
What problem are you trying to solve?
... explain What? Why? and How?
(optional)
... include a
Solution
How did you solve the problem?
How to test
Screenshots 📸 (optional)
If relevant, include screenshots
Anything Else? (optional)