Update LLVM to 13 (#538)

* Update dependencies

* Fix warnings

* Fix build

* Fix script

* Bump version

* TEST

* Revert "TEST"

This reverts commit 51f89c7.

* Use clang

* Remove targets from top-level rust-toolchain.toml

* Revert "Use clang"

This reverts commit 07a1159.

* Install gcc

* Revert "Install gcc"

This reverts commit 2e64f53.

* Install gcc

* Try using Ubuntu 18.04

* Revert "Install gcc"

This reverts commit 83302d5.

* Use Ubuntu 18.04 more

* Clean homebrew cache after setup

* Revert "Clean homebrew cache after setup"

This reverts commit 0e3445e.

* Revert "Remove targets from top-level rust-toolchain.toml"

This reverts commit b52d2b9.

.cargo/config.toml

@@ -0,0 +1,2 @@
+[build]
+rustflags = ["-A", "improper_ctypes", "-D", "improper_ctypes_definitions"]

.github/workflows/release.yaml

@@ -6,7 +6,7 @@ on:
   pull_request:
 jobs:
   tag_check:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     outputs:
       version: ${{ env.version }}
       should_release: ${{ env.should_release }}
@@ -25,7 +25,7 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - ubuntu-latest
+          - ubuntu-18.04
           - macos-latest
     runs-on: ${{ matrix.os }}
     steps:
@@ -40,7 +40,7 @@ jobs:
     needs:
       - tag_check
       - build_asset
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
         with:
@@ -63,7 +63,7 @@ jobs:
       - tag_check
       - release
     if: needs.tag_check.outputs.should_release == 'true'
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
         with:

.github/workflows/test.yaml

@@ -6,14 +6,14 @@ on:
   pull_request:
 jobs:
   build:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
       - run: tools/ci/set_up_os.sh
       - run: cargo build --locked
       - run: git diff --exit-code
   unit_test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-18.04
     steps:
       - uses: actions/checkout@v2
       - run: tools/ci/set_up_os.sh
@@ -23,7 +23,7 @@ jobs:
       fail-fast: false
       matrix:
         os:
-          - ubuntu-latest
+          - ubuntu-18.04
           - macos-latest
     runs-on: ${{ matrix.os }}
     steps:

doc/src/guides/install.md

@@ -26,7 +26,7 @@ You can also build Pen from source on your local machine.
 1. Install the following software using a package manager of your choice (e.g. `apt` for Ubuntu and [Homebrew][homebrew] for macOS.)
 
    - [Rust](https://www.rust-lang.org/)
-   - [LLVM 12](https://llvm.org/)
+   - [LLVM 13](https://llvm.org/)
    - [Git](https://git-scm.com/)
    - [Ninja](https://ninja-build.org/)
 

lib/infra/src/llvm_command_finder.rs

@@ -2,7 +2,7 @@ use crate::command_finder;
 use std::{error::Error, path::PathBuf};
 
 const MINIMUM_VERSION: usize = 11;
-const MAXIMUM_VERSION: usize = 12;
+const MAXIMUM_VERSION: usize = 13;
 
 pub fn find(command: &str) -> Result<PathBuf, Box<dyn Error>> {
     for version in (MINIMUM_VERSION..=MAXIMUM_VERSION).rev() {

tools/ci/set_up_os.sh

@@ -2,11 +2,13 @@
 
 set -e
 
-brew install jq llvm@12 ninja
+llvm_version=13
 
-llvm_prefix=$(brew --prefix)/opt/llvm@12
+brew install jq llvm@$llvm_version ninja
 
-echo LLVM_SYS_120_PREFIX=$llvm_prefix >>$GITHUB_ENV
+llvm_prefix=$(brew --prefix)/opt/llvm@$llvm_version
+
+echo LLVM_SYS_${llvm_version}0_PREFIX=$llvm_prefix >>$GITHUB_ENV
 echo PATH=$llvm_prefix/bin:$PATH >>$GITHUB_ENV
 
 if [ $RUNNER_OS = Linux ]; then

tools/lint.sh

@@ -18,8 +18,6 @@ install_nightly_component clippy
 
 $(dirname $0)/run_all_crates.sh \
   rustup run nightly cargo clippy $options -Z unstable-options -- \
-  -A improper_ctypes \
-  -D improper_ctypes_definitions \
   -D clippy::use_self \
   -D clippy::mod_module_files \
   "$@"