Fix build jobs (#2460)

.github/workflows/lint.yaml

@@ -20,12 +20,6 @@ jobs:
       - uses: actions/checkout@v4
       - uses: ./tools/ci/github/setup
       - run: tools/lint.sh -- -D warnings
-  unused_dependencies:
-    runs-on: ubuntu-22.04
-    steps:
-      - uses: actions/checkout@v4
-      - uses: ./tools/ci/github/setup
-      - run: tools/unused_dependencies.sh
   spell_check:
     runs-on: ubuntu-latest
     steps:

Dockerfile

@@ -1,6 +1,6 @@
 from ubuntu:20.04
 
-env DEBIAN_FRONTEND=noninteractive	
+env DEBIAN_FRONTEND=noninteractive
 
 run apt update --fix-missing && apt install -y \
 	build-essential \
@@ -26,7 +26,7 @@ shell ["bash", "-lc"]
 
 run git clone https://github.com/Homebrew/brew ~/.homebrew
 run ~/.homebrew/bin/brew shellenv >> ~/.profile
-run brew install hello
+run brew info hello
 
 run curl -fsSL https://sh.rustup.rs | sh /dev/stdin -y
 run cargo install mdbook sccache turtle-build

.cspell.json → cspell.json

@@ -45,6 +45,7 @@
     "libc",
     "malloc",
     "metaprogramming",
+    "metavars",
     "mfmt",
     "mkdocs",
     "modifiability",

lib/ffi/src/future/call_function.rs

@@ -20,6 +20,7 @@ macro_rules! call_function {
             let mut initialize = Some(|stack: &mut AsyncStack| {
                 let function = $function;
 
+                #[allow(clippy::macro_metavars_in_unsafe)]
                 unsafe { function(stack, resolve, $($argument),*) };
             });
 

lib/infra/src/ninja_build_script_runner.rs

@@ -43,7 +43,7 @@ impl app::infra::BuildScriptRunner for NinjaBuildScriptRunner {
                 .arg("--quiet")
                 .arg("-f")
                 .arg(&build_script_file)
-                .arg(&self.file_path_converter.convert_to_os_path(target_file))
+                .arg(self.file_path_converter.convert_to_os_path(target_file))
                 .stdout(Stdio::inherit())
                 .stderr(Stdio::inherit()),
         )?;

lib/infra/src/test_linker.rs

@@ -120,7 +120,7 @@ impl app::infra::TestLinker for TestLinker {
             command_runner::run_command(
                 Command::new("cp")
                     .arg("-r")
-                    .arg(&Path::new(&language_root_directory).join("cmd/test"))
+                    .arg(Path::new(&language_root_directory).join("cmd/test"))
                     .arg(&main_crate_directory),
             )?;
         }