Fix File Upload
#952
Open
Fix File Upload
#952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMartinOscar
requested review from
notAreYouScared,
Boy132 and
alexevladgabriel
RMartinOscar
force-pushed
the
fix/FileUpload
branch
from
cb066d1 to
1f975bb
Compare
Boy132
requested changes
Jan 27, 2025
| @@ -502,6 +502,7 @@ protected function getHeaderActions(): array | |||
| ->storeFiles(false) | |||
| ->previewable(false) | |||
| ->preserveFilenames() | |||
| ->maxSize($server->node->upload_size * config('panel.use_binary_prefix') ? 1024 : 1000) | |||
There was a problem hiding this comment.
As far as I can see maxSize always expects KiB (despite the filamentphp docs calling it KB). So we need to do some math when using decimal prefix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After