improved street intersection support #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added #108 to solve some of the USA highway names not parsing correctly. |
|
Added #110 to fix some other street name classsifications |
missinglink
force-pushed
the
intersection_improvements
branch
2 times, most recently
from
81a434e to
f741fe6
Compare
|
Added #111 |
missinglink
force-pushed
the
intersection_improvements
branch
from
f741fe6 to
3cb09c9
Compare
|
rebased |
missinglink
force-pushed
the
intersection_improvements
branch
from
3cb09c9 to
10e56d4
Compare
…ver three additional test cases
|
All but one test case are passing now, I've opened up #112 to tackle that separately. |
|
I think this is good-to-go now. The really complex intersection queries can take >50ms on my laptop which isn't ideal ;( |
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Jul 8, 2020
This includes all the latest intersection parsing abilities from pelias/parser#107
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Jul 10, 2020
This includes all the latest intersection parsing abilities from pelias/parser#107
orangejulius
added a commit
to pelias/api
that referenced
this pull request
Jul 10, 2020
This includes all the latest intersection parsing abilities from pelias/parser#107
blackmad
pushed a commit
to pelias/api
that referenced
this pull request
Jul 21, 2020
This includes all the latest intersection parsing abilities from pelias/parser#107
blackmad
pushed a commit
to pelias/api
that referenced
this pull request
Aug 4, 2020
This includes all the latest intersection parsing abilities from pelias/parser#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[note] don't bother reviewing this for now, it's made up of several smaller PRs which can be reviewed and merged independentlyA Geocode Earth client has requested that the
/v1/searchAPI in Pelias can identify and querystreet intersections(something whichlibpostalisn't able to support).We already support intersection parsing in
pelias/parserbut when I added some additional test cases I noticed a variety of failures due to the intersection solutions stripping away all admin info and some USA-centric street conventions we don't currently support.This PR is driven by the test cases added in the first commit, I'm going to try and get them all passing, as a result there may be some other linked PRs along the way to fix intermediary issues.