Pin to an exact pelias-parser version (2.1.0) #1585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically we've kept most Pelias NPM dependencies on carat versions, but because the Pelias Parser can cause changes in acceptance-test results for any change (minor or even bug fix), we've kept it pinned to a specific version so we can explicitly upgrade. Recently, we were on a [hotfix branch](#1531) of the parser, but while switching back to using a version specification, we switched to [using a carat range](#1565). While manually bumping the version on a frequent basis is a bit annoying, it helps avoid any chance that unexpected or untested parser changes will find their way into the API releases, so this change brings us back to a pin of the current latest version of the Pelias Parser.
missinglink
approved these changes
Nov 29, 2021
|
Yeah, agreed. In some ways it might have been good to put the parser code in the API repository. But there are also a lot of good reasons to not have done that. A bunch of manual version bumping work isn't the worst outcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically we've specified most Pelias NPM dependency versions using the caret (
^) range, but because the Pelias Parser can cause differences in acceptance-test results for any change (minor or even bug fix), we've kept that dependency in particular pinned to a specific version so we can control upgrades more carefully.Recently, we were on a hotfix branch of the parser, but while switching back , we switched to using a caret range.
While manually bumping the version on a frequent basis is a bit annoying, it helps avoid any chance that unexpected or untested parser changes will find their way into the API releases.
This change brings us back to a pin of the current latest version of the Pelias Parser.