Lint PHP files in CI #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jparise
force-pushed
the
ci-lint
branch
4 times, most recently
from
562ada5 to
d3ef3f3
Compare
`php -l` didn't handle multiple source file arguments until PHP 8.2 so
we need to use a loop to process everything.
We have an outstanding lint error in Log/sql.php under PHP 7.x ("mixed
property cannot have a default value"). For now, just skip running lint
on that version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php -ldidn't handle multiple source file arguments until PHP 8.2 sowe need to use a loop to process everything.
We have an outstanding lint error in Log/sql.php under PHP 7.x ("mixed
property cannot have a default value"). For now, just skip running lint
on that version.