Merge main #4018
Merge main #4018
Conversation
…mpty line symbols
…al empty line handling
…andling, and transform improvements
… seconds and centiseconds
…nd simplify seekTo handler
…ve transform calc
…fast-scroll on tab visible
…mpty line symbols
… seconds and centiseconds
…nd simplify seekTo handler
…ve transform calc
…fast-scroll on tab visible
… clean rendering logic
…ve animation behavior
syncs changes with upstream repo
|
apologies, opened by mistake |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
eslint
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'plugins.downloader.backend.dialog.start-download-playlist.title' with ⏎········'plugins.downloader.backend.dialog.start-download-playlist.title',⏎······
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'info',·'⚙️·yt-dlp·command:',·${ytDlpPath}·${args.join('·')}`` with ⏎······'info',⏎······'⚙️·yt-dlp·command:',⏎······${ytDlpPath}·${args.join('·')}`,⏎····`
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'info',·'📥·yt-dlp·output:',·chunk.trim().substring(0,·200) with ⏎··········'info',⏎··········'📥·yt-dlp·output:',⏎··········chunk.trim().substring(0,·200),⏎········
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace !isNaN(progress)·&&·progress·>·0·&&·progress·!==·lastProgressUpdate with ⏎··········!isNaN(progress)·&&⏎··········progress·>·0·&&⏎··········progress·!==·lastProgressUpdate⏎········
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'info',·📊·Playlist·progress:·${Math.floor(progress··100)}%`` with ⏎············'info',⏎············📊·Playlist·progress:·${Math.floor(progress··100)}%`,⏎··········`
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ``Downloading...·${Math.floor(progress··100)}%,·progress with `⏎············`Downloading...·${Math.floor(progress··100)}%`,⏎············progress,⏎··········`
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'info',·'✅·Track·completed:',·path.basename(filename[1]) with ⏎············'info',⏎············'✅·Track·completed:',⏎············path.basename(filename[1]),⏎··········
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'warn',·'⚠️·yt-dlp·stderr:',·errorChunk.trim().substring(0,·200) with ⏎········'warn',⏎········'⚠️·yt-dlp·stderr:',⏎········errorChunk.trim().substring(0,·200),⏎······
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace \nCommand:·${ytDlpPath}·${args.join('·')} with ··\nCommand:·${ytDlpPath}·${args.join('·')},
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ()·=>·{} with ⏎······()·=>·{},⏎····
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·typeof·config.advanced?.ytDlpPath·===·'string'·?·config.advanced.ytDlpPath with ⏎··········typeof·config.advanced?.ytDlpPath·===·'string'⏎············?·config.advanced.ytDlpPath⏎···········
pear-desktop/src/plugins/downloader/menu.ts
Line 201 in e804683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎
pear-desktop/src/plugins/downloader/menu.ts
Line 248 in e804683
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎
'chevronLeft' is assigned a value but never used.
'chevronRight' is assigned a value but never used.
'successIcon' is assigned a value but never used.
'errorIcon' is assigned a value but never used.
'notFoundIcon' is assigned a value but never used.
| @@ -0,0 +1,140 @@ | |||
| import path from 'node:path'; | |||
| import fs, { promises as fsPromises } from 'node:fs'; | |||
| import { createHash } from 'node:crypto'; | |||
There was a problem hiding this comment.
🚫 [eslint] <importPlugin/order> reported by reviewdog 🐶
There should be at least one empty line between import groups
| import { createHash } from 'node:crypto'; | |
| import { createHash } from 'node:crypto'; | |
| import path from 'node:path'; | ||
| import fs, { promises as fsPromises } from 'node:fs'; | ||
| import { createHash } from 'node:crypto'; | ||
| import { app, net, Session } from 'electron'; |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/consistent-type-imports> reported by reviewdog 🐶
Imports "Session" are only used as type.
| import { app, net, Session } from 'electron'; | |
| import { app, net, type Session } from 'electron'; |
| import fs, { promises as fsPromises } from 'node:fs'; | ||
| import { createHash } from 'node:crypto'; | ||
| import { app, net, Session } from 'electron'; | ||
| import { ElectronBlocker } from '@ghostery/adblocker-electron'; |
There was a problem hiding this comment.
🚫 [eslint] <importPlugin/order> reported by reviewdog 🐶
There should be at least one empty line between import groups
| import { ElectronBlocker } from '@ghostery/adblocker-electron'; | |
| import { ElectronBlocker } from '@ghostery/adblocker-electron'; | |
| this.isRunning = true; | ||
| } | ||
|
|
||
| public async stop() { |
There was a problem hiding this comment.
🚫 [eslint] <@typescript-eslint/require-await> reported by reviewdog 🐶
Async method 'stop' has no 'await' expression.
| } | ||
| } | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ⏎
| } | |
| } | |
| const ytDlpPath = getYtDlpPath(config.advanced?.ytDlpPath); | ||
| if (!ytDlpPath) { | ||
| const allPaths = [ | ||
| config.advanced?.ytDlpPath ? `[custom] ${config.advanced.ytDlpPath}` : null, |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace ·?·[custom]·${config.advanced.ytDlpPath}`` with ⏎········?·[custom]·${config.advanced.ytDlpPath}`⏎·······`
| config.advanced?.ytDlpPath ? `[custom] ${config.advanced.ytDlpPath}` : null, | |
| config.advanced?.ytDlpPath | |
| ? `[custom] ${config.advanced.ytDlpPath}` | |
| : null, |
| : []), | ||
| ].filter(Boolean); | ||
|
|
||
| logToFrontend('error', '❌ yt-dlp not found for playlist. Paths checked:', allPaths); |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'error',·'❌·yt-dlp·not·found·for·playlist.·Paths·checked:',·allPaths with ⏎······'error',⏎······'❌·yt-dlp·not·found·for·playlist.·Paths·checked:',⏎······allPaths,⏎····
| logToFrontend('error', '❌ yt-dlp not found for playlist. Paths checked:', allPaths); | |
| logToFrontend( | |
| 'error', | |
| '❌ yt-dlp not found for playlist. Paths checked:', | |
| allPaths, | |
| ); |
| new Error( | ||
| 'yt-dlp executable not found.\nPaths checked:\n' + | ||
| allPaths.join('\n') + | ||
| '\nPlease set the path in the Downloader plugin menu.' |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
| '\nPlease set the path in the Downloader plugin menu.' | |
| '\nPlease set the path in the Downloader plugin menu.', |
| 'yt-dlp executable not found.\nPaths checked:\n' + | ||
| allPaths.join('\n') + | ||
| '\nPlease set the path in the Downloader plugin menu.' | ||
| ) |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Insert ,
| ) | |
| ), |
| const dialogResult = await dialog.showMessageBox(win, { | ||
| type: 'info', | ||
| buttons: [ | ||
| t('plugins.downloader.backend.dialog.start-download-playlist.buttons.ok'), |
There was a problem hiding this comment.
🚫 [eslint] <prettier/prettier> reported by reviewdog 🐶
Replace 'plugins.downloader.backend.dialog.start-download-playlist.buttons.ok' with ⏎··········'plugins.downloader.backend.dialog.start-download-playlist.buttons.ok',⏎········
| t('plugins.downloader.backend.dialog.start-download-playlist.buttons.ok'), | |
| t( | |
| 'plugins.downloader.backend.dialog.start-download-playlist.buttons.ok', | |
| ), |
2 participants
No description provided.