feat(synced-lyrics): add enhanced line effect, improve character display, and fix provider handling

src/config/store.ts

@@ -11,6 +11,42 @@ export type IStore = InstanceType<
 >;
 
 const migrations = {
+  '>=3.12.0'(store: IStore) {
+    // Synced Lyrics: migrate placeholder defaults
+    const syncedLyricsConfig = store.get('plugins.synced-lyrics') as
+      | SyncedLyricsPluginConfig
+      | undefined;
+
+    if (!syncedLyricsConfig) return;
+
+    const current = syncedLyricsConfig.defaultTextString as
+      | string
+      | string[]
+      | undefined;
+    let updatedValue: string | string[] | undefined;
+
+    if (Array.isArray(current)) {
+      const asJson = JSON.stringify(current);
+      // Migrate progressive sequences to non-cumulative variants
+      if (asJson === JSON.stringify(['•', '••', '•••'])) {
+        updatedValue = ['•', '•', '•'];
+      } else if (asJson === JSON.stringify(['.', '..', '...'])) {
+        updatedValue = ['.', '.', '.'];
+      }
+    } else if (typeof current === 'string') {
+      // Replace regular space placeholder with NBSP to preserve layout
+      if (current === ' ') {
+        updatedValue = '\u00A0';
+      }
+    }
+
+    if (updatedValue !== undefined) {
+      store.set('plugins.synced-lyrics', {
+        ...syncedLyricsConfig,
+        defaultTextString: updatedValue,
+      } as SyncedLyricsPluginConfig);
+    }
+  },
   '>=3.10.0'(store: IStore) {
     const lyricGeniusConfig = store.get('plugins.lyrics-genius') as
       | {

src/i18n/resources/en.json

@@ -828,6 +828,10 @@
         "line-effect": {
           "label": "Line effect",
           "submenu": {
+            "enhanced": {
+              "label": "Enhanced",
+              "tooltip": "A refined lyric effect for smoother, more enjoyable reading."
+            },
             "fancy": {
               "label": "Fancy",
               "tooltip": "Use large, app-like effects on the current line"
@@ -847,6 +851,10 @@
           },
           "tooltip": "Choose the effect to apply to the current line"
         },
+        "show-empty-line-symbols": {
+          "label": "Show character between lyrics",
+          "tooltip": "Choose whether to always display the character between empty lyric lines."
+        },
         "precise-timing": {
           "label": "Make the lyrics perfectly synced",
           "tooltip": "Calculate to the milisecond the display of the next line (can have a small impact on performance)"

src/plugins/synced-lyrics/index.ts

@@ -11,16 +11,17 @@ import type { SyncedLyricsPluginConfig } from './types';
 export default createPlugin({
   name: () => t('plugins.synced-lyrics.name'),
   description: () => t('plugins.synced-lyrics.description'),
-  authors: ['Non0reo', 'ArjixWasTaken', 'KimJammer', 'Strvm'],
+  authors: ['Non0reo', 'ArjixWasTaken', 'KimJammer', 'Strvm', 'robroid'],
   restartNeeded: true,
   addedVersion: '3.5.X',
   config: {
     enabled: false,
     preciseTiming: true,
     showLyricsEvenIfInexact: true,
     showTimeCodes: false,
-    defaultTextString: '♪',
-    lineEffect: 'fancy',
+    defaultTextString: '•••',
+    lineEffect: 'enhanced',
+    showEmptyLineSymbols: true,
     romanization: true,
   } satisfies SyncedLyricsPluginConfig as SyncedLyricsPluginConfig,
 

src/plugins/synced-lyrics/menu.ts

@@ -41,22 +41,26 @@ export const menu = async (
         ),
       ],
     },
-    {
-      label: t('plugins.synced-lyrics.menu.precise-timing.label'),
-      toolTip: t('plugins.synced-lyrics.menu.precise-timing.tooltip'),
-      type: 'checkbox',
-      checked: config.preciseTiming,
-      click(item) {
-        ctx.setConfig({
-          preciseTiming: item.checked,
-        });
-      },
-    },
     {
       label: t('plugins.synced-lyrics.menu.line-effect.label'),
       toolTip: t('plugins.synced-lyrics.menu.line-effect.tooltip'),
       type: 'submenu',
       submenu: [
+        {
+          label: t(
+            'plugins.synced-lyrics.menu.line-effect.submenu.enhanced.label',
+          ),
+          toolTip: t(
+            'plugins.synced-lyrics.menu.line-effect.submenu.enhanced.tooltip',
+          ),
+          type: 'radio',
+          checked: config.lineEffect === 'enhanced',
+          click() {
+            ctx.setConfig({
+              lineEffect: 'enhanced',
+            });
+          },
+        },
         {
           label: t(
             'plugins.synced-lyrics.menu.line-effect.submenu.fancy.label',
@@ -124,23 +128,52 @@ export const menu = async (
       toolTip: t('plugins.synced-lyrics.menu.default-text-string.tooltip'),
       type: 'submenu',
       submenu: [
-        { label: '♪', value: '♪' },
-        { label: '" "', value: ' ' },
-        { label: '...', value: ['.', '..', '...'] },
-        { label: '•••', value: ['•', '••', '•••'] },
-        { label: '———', value: '———' },
-      ].map(({ label, value }) => ({
-        label,
-        type: 'radio',
-        checked:
-          typeof value === 'string'
-            ? config.defaultTextString === value
-            : JSON.stringify(config.defaultTextString) ===
-              JSON.stringify(value),
-        click() {
-          ctx.setConfig({ defaultTextString: value });
+        ...[
+          { label: '•••', value: ['•', '•', '•'] },
+          { label: '...', value: ['.', '.', '.'] },
+          { label: '♪', value: '♪' },
+          { label: '———', value: '———' },
+          { label: '(𝑏𝑙𝑎𝑛𝑘)', value: '\u00A0' },
+        ].map(
+          ({ label, value }) =>
+            ({
+              label,
+              type: 'radio',
+              checked:
+                JSON.stringify(config.defaultTextString) ===
+                JSON.stringify(value),
+              enabled: config.showEmptyLineSymbols,
+              click() {
+                ctx.setConfig({ defaultTextString: value });
+              },
+            }) as const,
+        ),
+        { type: 'separator' },
+        {
+          label: t('plugins.synced-lyrics.menu.show-empty-line-symbols.label'),
+          toolTip: t(
+            'plugins.synced-lyrics.menu.show-empty-line-symbols.tooltip',
+          ),
+          type: 'checkbox',
+          checked: config.showEmptyLineSymbols ?? false,
+          click(item) {
+            ctx.setConfig({
+              showEmptyLineSymbols: item.checked,
+            });
+          },
         },
-      })),
+      ],
+    },
+    {
+      label: t('plugins.synced-lyrics.menu.precise-timing.label'),
+      toolTip: t('plugins.synced-lyrics.menu.precise-timing.tooltip'),
+      type: 'checkbox',
+      checked: config.preciseTiming,
+      click(item) {
+        ctx.setConfig({
+          preciseTiming: item.checked,
+        });
+      },
     },
     {
       label: t('plugins.synced-lyrics.menu.romanization.label'),

src/plugins/synced-lyrics/parsers/lrc.ts

@@ -1,3 +1,8 @@
+import {
+  ensureLeadingPaddingEmptyLine,
+  mergeConsecutiveEmptySyncedLines,
+} from '../shared/lines';
+
 interface LRCTag {
   tag: string;
   value: string;
@@ -17,7 +22,7 @@ interface LRC {
 
 const tagRegex = /^\[(?<tag>\w+):\s*(?<value>.+?)\s*\]$/;
 // prettier-ignore
-const lyricRegex = /^\[(?<minutes>\d+):(?<seconds>\d+)\.(?<milliseconds>\d+)\](?<text>.+)$/;
+const lyricRegex = /^\[(?<minutes>\d+):(?<seconds>\d+)\.(?<milliseconds>\d{1,3})\](?<text>.*)$/;
 
 export const LRC = {
   parse: (text: string): LRC => {
@@ -50,13 +55,18 @@ export const LRC = {
       }
 
       const { minutes, seconds, milliseconds, text } = lyric;
-      const timeInMs =
-        parseInt(minutes) * 60 * 1000 +
-        parseInt(seconds) * 1000 +
-        parseInt(milliseconds);
+
+      // Normalize: take first 2 digits, pad if only 1 digit
+      const ms2 = milliseconds.padEnd(2, '0').slice(0, 2);
+
+      // Convert to ms (xx → xx0)
+      const minutesMs = parseInt(minutes) * 60 * 1000;
+      const secondsMs = parseInt(seconds) * 1000;
+      const centisMs = parseInt(ms2) * 10;
+      const timeInMs = minutesMs + secondsMs + centisMs;
 
       const currentLine: LRCLine = {
-        time: `${minutes}:${seconds}:${milliseconds}`,
+        time: `${minutes.padStart(2, '0')}:${seconds.padStart(2, '0')}.${ms2}`,
         timeInMs,
         text: text.trim(),
         duration: Infinity,
@@ -74,15 +84,11 @@ export const LRC = {
       line.timeInMs += offset;
     }
 
-    const first = lrc.lines.at(0);
-    if (first && first.timeInMs > 300) {
-      lrc.lines.unshift({
-        time: '0:0:0',
-        timeInMs: 0,
-        duration: first.timeInMs,
-        text: '',
-      });
-    }
+    // leading padding line if the first line starts late
+    lrc.lines = ensureLeadingPaddingEmptyLine(lrc.lines, 300, 'span');
+
+    // Merge consecutive empty lines into a single empty line
+    lrc.lines = mergeConsecutiveEmptySyncedLines(lrc.lines);
 
     return lrc;
   },