Prioritize synced lyrics and improved artist value for lyrics on videos #3254
Conversation
|
Nice idea, but ontop of that I propose you construct an array of all the queries to be made, and iterate over it. e.g. const queries = [`${info.artist} - ${info.title}`];
if (info.alternativeTitle) queries.push(`${info.artist} - ${info.alternativeTitle}`);
if (info.album) {
queries.push(`${info.album} - ${info.title}`);
if (info.alternativeTitle) queries.push(`${info.album} - ${info.alternativeTitle}`);
}
let lyrics = null;
for (const query of queries) {
const results = await ...;
lyrics = ...;
if (lyrics) break;
}
...heck, you may even gather all the search results from all the queries and do the filter on all of them |
|
To put my two cents here, I've done a quick test on your branch and the fixes from my PR seem to still work in the songs I tested, however I noticed the searching for LRCLIB seem to be much slower. Might just be me not noticing before though I'll look into it further if I have the time. |
|
TODO: Prioritize album name using jaroWinkler BIGBANG - Fantastic Baby EDIT: |
# Conflicts: # src/plugins/synced-lyrics/providers/LRCLib.ts
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const weightDuration = 0.3; | ||
|
|
||
| const scoreA = | ||
| weightAlbumRatio * arA! - weightDuration * normalizedDurationA; |
There was a problem hiding this comment.
Unexpected mix of '*' and '-'. Use parentheses to clarify the intended order of operations.
| const weightDuration = 0.3; | ||
|
|
||
| const scoreA = | ||
| weightAlbumRatio * arA! - weightDuration * normalizedDurationA; |
There was a problem hiding this comment.
Unexpected mix of '*' and '-'. Use parentheses to clarify the intended order of operations.
| const weightDuration = 0.3; | ||
|
|
||
| const scoreA = | ||
| weightAlbumRatio * arA! - weightDuration * normalizedDurationA; |
There was a problem hiding this comment.
Unexpected mix of '-' and '*'. Use parentheses to clarify the intended order of operations.
| const weightDuration = 0.3; | ||
|
|
||
| const scoreA = | ||
| weightAlbumRatio * arA! - weightDuration * normalizedDurationA; |
There was a problem hiding this comment.
Unexpected mix of '-' and '*'. Use parentheses to clarify the intended order of operations.
| const scoreA = | ||
| weightAlbumRatio * arA! - weightDuration * normalizedDurationA; | ||
| const scoreB = | ||
| weightAlbumRatio * arB! - weightDuration * normalizedDurationB; |
There was a problem hiding this comment.
Unexpected mix of '*' and '-'. Use parentheses to clarify the intended order of operations.
| const scoreA = | ||
| weightAlbumRatio * arA! - weightDuration * normalizedDurationA; | ||
| const scoreB = | ||
| weightAlbumRatio * arB! - weightDuration * normalizedDurationB; |
There was a problem hiding this comment.
Unexpected mix of '*' and '-'. Use parentheses to clarify the intended order of operations.
| const scoreA = | ||
| weightAlbumRatio * arA! - weightDuration * normalizedDurationA; | ||
| const scoreB = | ||
| weightAlbumRatio * arB! - weightDuration * normalizedDurationB; |
There was a problem hiding this comment.
Unexpected mix of '-' and '*'. Use parentheses to clarify the intended order of operations.
| const scoreA = | ||
| weightAlbumRatio * arA! - weightDuration * normalizedDurationA; | ||
| const scoreB = | ||
| weightAlbumRatio * arB! - weightDuration * normalizedDurationB; |
There was a problem hiding this comment.
Unexpected mix of '-' and '*'. Use parentheses to clarify the intended order of operations.
4 participants
Hi
With the artist value i achive to resolve #3117
And prioritize lyrics improve a bit #3206
Ex. starseed was displaying the plain lyrics
This is my very first PR, let me know if somethings is wrong.