Skip to content

Conversation

ArjixWasTaken
Copy link
Member

@ArjixWasTaken ArjixWasTaken commented Mar 7, 2025

About

This is a plugin that introduces a new settings interface!
Configuring everything through menu options is not only a pain, but it is also a pain! (double pain!)
I propose that this plugin is enabled by default, but I won't insist on that if you think otherwise.

TODO

  • Add settings button
  • Add settings modal
    • General
    • Appearance
    • Plugins
    • Advanced
    • About

Screenshots

Full sidebar Mini sidebar
image image

general

@ArjixWasTaken
Copy link
Member Author

ArjixWasTaken commented Mar 7, 2025

Before I develop this further, I'd like your opinions, any suggestions as to what/how the settings should look like?

@th-ch, @JellyBrick, @Su-Yong

Edit: 2 weeks have passed w/o any message, so I'll continue with whatever I think looks best.

@ArjixWasTaken ArjixWasTaken changed the title feat(settings-ui): init feat: settings-ui Mar 7, 2025
@ArjixWasTaken ArjixWasTaken changed the title feat: settings-ui feat(plugin): settings-ui Mar 7, 2025
@JellyBrick JellyBrick added the enhancement New feature or request label Mar 24, 2025
@ArjixWasTaken
Copy link
Member Author

ArjixWasTaken commented Apr 6, 2025

Question:

Should the settings:
a) be applied as soon as you change them (like the menu)
b) be applied after pressing a confirm button to close the modal

@JellyBrick, @th-ch

@Rairof
Copy link

Rairof commented Apr 29, 2025

#3066 (comment)
a) Imo as that's the expected behaviour most users would think of. Also so the users won't be confused as to why their selected settings don't work immediately.
It would be better if a pop up to restart the client is shown with settings that needs a restart to take effect.
PS ignore my suggestion if I (a user) am not qualified or supposed to suggest or share anything here. I just wanted to give my two cents on what I think would be best for the users overall.

@ArjixWasTaken
Copy link
Member Author

@Rairof you didn't understand what I meant, so of course you'd think so

I meant we'd not allow the user to close their settings unless there are no unsaved changes, just like how discord does it

@Rairof
Copy link

Rairof commented Apr 29, 2025

#3066 (comment)
In that case. my proposal was to automatically apply said user changes inside the settings menu (like how it is now with the in-app menu) with the sole exception being the few plugins/functions that require a restart to function.

@JellyBrick
Copy link
Collaborator

Question:

Should the settings: a) be applied as soon as you change them (like the menu) b) be applied after pressing a confirm button to close the modal

@JellyBrick, @th-ch

a + throttle (e.g. 5sec)

github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

@ArjixWasTaken
Copy link
Member Author

ArjixWasTaken commented Oct 12, 2025

new UI using mdui:

image

🎊

looks so much more better now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants