-
-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added support for nested classes; this is basically a newer version o… #390
base: master
Are you sure you want to change the base?
Conversation
…f angeloskath's commit 467350c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up again!
Would you care to add a small unit test to show this new feature works as advertised and so we don't break it later?
…o Class._classes() and Class.all_classes() to Class.classes()
…into nested_classes
@kernc: you might want to wait with the next review, I've discovered a problem regarding warnings being issued, which I've already resolved. But there are also cases where member types are not properly rendered as hyperlinks in html output. The latter problem is due to the usage of |
@kernc: I just pushed new changes which fix a problem nested classes being recognized as |
The test tries to ensure that only the identifiers in pdoc/pdoc/test/example_pkg/__init__.py Lines 111 to 112 in 2cce30a
|
Co-authored-by: kernc <[email protected]>
…o test_nested_classes
@frank101010 @kernc Is this good to go? I require this functionality and can work on the PR by reopening on my own fork if you don't have time. Thanks, |
456869b
to
94d26e8
Compare
Adds support for nested classes to pdoc3.
This is basically a newer version of angeloskath's commit 467350c, #176, but since I need support for nested classes, and the original merge request hasn't changed status since June 2020, I decided to apply most of angeloskath's changes into a branch derived from the most recent master.
(deleted section about unit test problems, which were resolved after running tests on an os supporting symbolic links)