alac: validate mid_side_shift to not overflow

pdeljanov · Jan 17, 2025 · 6788d7c · 6788d7c
1 parent 0d10b52
commit 6788d7c
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/symphonia-codec-alac/src/lib.rs b/symphonia-codec-alac/src/lib.rs
@@ -658,6 +658,12 @@ fn decode_sce_or_cpe<B: ReadBitsLtr>(
             elem1.predict(&mut out1[..num_samples])?;
 
             if mid_side_weight != 0 {
+                // mid_side_shift should not be bigger than 31 bits as we are shifting i32 to the right
+                // TODO validate if it should be not bigger than config.bit_depth
+                if mid_side_shift > 31 {
+                    return decode_error("alac: mid_side_shift is greater than 31 bit");
+                }
+
                 decorrelate_mid_side(out0, out1, mid_side_weight, mid_side_shift);
             }
         }