Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing white background outline at sides of dark color chips (on darker background) Fix for Issue #135 #137

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
13 changes: 7 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
## [NOT CURRENTLY MAINTAINED]

# MaterialChipsInput
This library is forked from [pchmn/MaterialChipsInput](https://github.com/pchmn/MaterialChipsInput)
The difference is removing of redundant white background from chip_view, thus darker chips are not seen with thin white outline on darker backgrounds.. (there were white pixels on the sides of chips)


Implementation of Material Design [Chips](https://material.io/guidelines/components/chips.html) component for Android. The library provides two views : [`ChipsInput`](#chipsinput) and [`ChipView`](#chipview).

[![Release](https://jitpack.io/v/pchmn/MaterialChipsInput.svg)](https://jitpack.io/#pchmn/MaterialChipsInput)
[![Release](https://jitpack.io/v/pchmn/MaterialChipsInput.svg)](https://jitpack.io/#techwizard1/MaterialChipsInput)

<img src="https://github.com/pchmn/MaterialChipsInput/blob/master/docs/demo2.gif" alt="Demo" height="600px"/>
<img src="https://github.com/techwizard1/MaterialChipsInput/blob/master/docs/demo2.gif" alt="Demo" height="600px"/>

## Demo
[Download sample-v1.0.8.apk](https://github.com/pchmn/MaterialChipsInput/raw/master/docs/material-chips-input-sample-v1.0.8.apk)
[Download sample-v1.0.8.apk](https://github.com/techwizard1/MaterialChipsInput/raw/master/docs/material-chips-input-sample-v1.0.9.apk)

## Setup

Expand All @@ -28,7 +29,7 @@ allprojects {
In your app level build.gradle :
```java
dependencies {
compile 'com.github.pchmn:MaterialChipsInput:1.0.8'
compile 'com.github.n-droidev:MaterialChipsInput:1.0.9'
}
```
<br><br>
Expand Down
8 changes: 8 additions & 0 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,10 @@ buildscript {
repositories {
jcenter()
mavenCentral()
maven {
url 'https://maven.google.com/'
name 'Google'
}
}
dependencies {
classpath 'com.android.tools.build:gradle:2.3.0'
Expand All @@ -20,6 +24,10 @@ allprojects {
repositories {
jcenter()
mavenCentral()
maven {
url 'https://maven.google.com/'
name 'Google'
}
}
}

Expand Down
12 changes: 6 additions & 6 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ android {
defaultConfig {
minSdkVersion 15
targetSdkVersion 25
versionCode 9
versionName "1.0.8"
versionCode 10
versionName "1.0.9"

testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"

Expand All @@ -27,15 +27,15 @@ dependencies {
androidTestCompile('com.android.support.test.espresso:espresso-core:2.2.2', {
exclude group: 'com.android.support', module: 'support-annotations'
})
compile 'com.android.support:appcompat-v7:25.3.0'
testCompile 'junit:junit:4.12'
compile 'com.android.support:appcompat-v7:25.4.0'
testCompile 'junit:junit:4.13'

// recycler
compile 'com.android.support:recyclerview-v7:25.3.0'
compile 'com.android.support:recyclerview-v7:25.4.0'
compile 'com.beloo.widget:ChipsLayoutManager:0.3.7@aar'

// circle image view
compile 'de.hdodenhof:circleimageview:2.1.0'
compile 'de.hdodenhof:circleimageview:3.1.0'

// butter knife
compile 'com.jakewharton:butterknife:8.5.1'
Expand Down
5 changes: 2 additions & 3 deletions library/src/main/res/layout/chip_view.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,7 @@
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/container"
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:background="@drawable/bg_chip_view">
android:layout_height="wrap_content">

<!-- content -->
<LinearLayout
Expand Down Expand Up @@ -46,4 +45,4 @@

</LinearLayout>

</RelativeLayout>
</RelativeLayout>
14 changes: 7 additions & 7 deletions sample/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ android {
applicationId "com.pchmn.sample.materialchipsinput"
minSdkVersion 15
targetSdkVersion 25
versionCode 9
versionName "1.0.8"
versionCode 10
versionName "1.0.9"
testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
}
buildTypes {
Expand All @@ -31,13 +31,13 @@ dependencies {
exclude group: 'com.android.support', module: 'support-annotations'
})
compile project(path: ':library')
testCompile 'junit:junit:4.13'
compile 'com.android.support:appcompat-v7:25.4.0'
compile 'com.android.support.constraint:constraint-layout:1.1.3'
compile 'io.reactivex.rxjava2:rxjava:2.2.19'
compile 'com.tbruyelle.rxpermissions2:rxpermissions:0.9.3@aar'

// butter knife
compile 'com.android.support:appcompat-v7:25.3.0'
compile 'com.android.support.constraint:constraint-layout:1.0.2'
compile 'io.reactivex.rxjava2:rxjava:2.0.8'
compile 'com.tbruyelle.rxpermissions2:rxpermissions:0.9.3@aar'
compile 'com.jakewharton:butterknife:8.5.1'
testCompile 'junit:junit:4.12'
annotationProcessor 'com.jakewharton:butterknife-compiler:8.5.1'
}