Skip to content

feat(keys): default keymap for pccx commands #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hkimw merged 1 commit into from
May 20, 2026
Merged

feat(keys): default keymap for pccx commands #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions editors/vscode-prototype/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,28 @@
"title": "PCCX: Show Trace Inspect Help"
}
],
"keybindings": [
{
"command": "pccxSystemVerilog.v0021.showKv260StatusPanel",
"key": "ctrl+alt+k",
"mac": "cmd+alt+k"
},
{
"command": "pccxSystemVerilog.v0021.openRunbook",
"key": "ctrl+alt+r",
"mac": "cmd+alt+r"
},
{
"command": "pccxSystemVerilog.v0021.openProjectBoard",
"key": "ctrl+alt+p",
"mac": "cmd+alt+p"
},
{
"command": "pccxSystemVerilog.v0021.showTraceInspectHelp",
"key": "ctrl+alt+i",
"mac": "cmd+alt+i"
}
],
"configuration": {
"title": "PCCX SystemVerilog IDE Prototype",
"properties": {
Expand Down
37 changes: 37 additions & 0 deletions editors/vscode-prototype/test/extension-manifest.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,29 @@ const V0021_COMMAND_TITLES = new Map([
["pccxSystemVerilog.v0021.showTraceInspectHelp", "PCCX: Show Trace Inspect Help"],
]);

const V0021_KEYBINDINGS = [
{
command: "pccxSystemVerilog.v0021.showKv260StatusPanel",
key: "ctrl+alt+k",
mac: "cmd+alt+k",
},
{
command: "pccxSystemVerilog.v0021.openRunbook",
key: "ctrl+alt+r",
mac: "cmd+alt+r",
},
{
command: "pccxSystemVerilog.v0021.openProjectBoard",
key: "ctrl+alt+p",
mac: "cmd+alt+p",
},
{
command: "pccxSystemVerilog.v0021.showTraceInspectHelp",
key: "ctrl+alt+i",
mac: "cmd+alt+i",
},
];

async function readText(path) {
return readFile(path, "utf8");
}
Expand Down Expand Up @@ -126,6 +149,19 @@ async function testCommandContributions() {
assert.equal(contributedCommands.size, COMMAND_IDS.length);
}

async function testV0021DefaultKeybindings() {
const manifest = await readPackageJson();
const keybindings = manifest.contributes?.keybindings;

assert.deepEqual(keybindings, V0021_KEYBINDINGS);
for (const keybinding of keybindings) {
assert.ok(COMMAND_IDS.includes(keybinding.command));
assert.match(keybinding.key, /^ctrl\+alt\+[a-z]$/);
assert.match(keybinding.mac, /^cmd\+alt\+[a-z]$/);
assert.equal(Object.hasOwn(keybinding, "when"), false);
}
}

async function testDocsKeepExperimentalScope() {
const readme = await readText(resolve(EXTENSION_ROOT, "README.md"));
const contract = await readText(resolve(ROOT, "docs/EDITOR_BRIDGE_CONTRACT.md"));
Expand Down Expand Up @@ -165,6 +201,7 @@ async function testDocsKeepExperimentalScope() {
await testPackageManifestShape();
await testNoMarketplacePublishingShape();
await testCommandContributions();
await testV0021DefaultKeybindings();
await testDocsKeepExperimentalScope();

console.log("vscode extension manifest tests ok");