Converted all Assests to .webp format #261
Conversation
Bibisha06
requested review from
SkySingh04,
2004yash,
alfiyafatima09,
0Xero7 and
mohit-nagaraj
as code owners
components/share.tsx
Outdated
| @@ -170,7 +171,7 @@ const Share: React.FC<ShareProps> = () => { | |||
| <div className="bg-gradient-to-tr from-gray-900 to-indigo-800 p-6 rounded-lg shadow-md text-white rounded-xl flex flex-col h-full"> | |||
| <div className="flex justify-start mb-4 items-center"> | |||
| <Image | |||
| src="https://img.icons8.com/?size=100&id=62856&format=png&color=000000" | |||
| src="https://img.icons8.com/?size=100&id=62856&format=webp&color=000000" | |||
There was a problem hiding this comment.
This wudnt work i believe? could u check this one... attach ss if possible
package.json
Outdated
| @@ -71,6 +70,7 @@ | |||
| "eslint": "8.57.1", | |||
| "eslint-config-next": "14.2.13", | |||
| "postcss": "^8.4.32", | |||
| "tailwindcss": "^3.3.6" | |||
| "tailwindcss": "^3.3.6", | |||
| "typescript": "5.8.2" | |||
There was a problem hiding this comment.
why was this dependency changed
utils/webpImages.ts
Outdated
| @@ -0,0 +1,8 @@ | |||
| export const convertToWebP = (url: string): string => { | |||
There was a problem hiding this comment.
could you explain the need of this function? if we gave already converted it why do we need utility function. the better approach would be updating those details from db as well
| }); | ||
|
|
||
| // Apply the external `convertToWebP` function if required | ||
| webpUrl = convertToWebP(webpUrl); // This ensures the URL is properly formatted |
There was a problem hiding this comment.
Is this necessary here?
utils/webpImages.ts
Outdated
| return url.replace(/\.(jpg|jpeg|png)$/, ".webp"); // Convert local images | ||
| } | ||
| if (!url.includes("cloudinary.com")) return url; // If not Cloudinary, return as is | ||
| return url.replace("/upload/", "/upload/f_webp/"); // Modify Cloudinary URL |
There was a problem hiding this comment.
why do we have this url replaced to f_webp?
components/achievementList.tsx
Outdated
| img: "sihlogo.webp", | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
there are so many changes which went missing from original coud u take a look here
| @@ -71,6 +74,15 @@ import { UploadApiResponse } from "cloudinary"; | |||
| */ | |||
| export async function POST(request: Request): Promise<Response> { | |||
| try { | |||
| // Check if the Content-Type header is multipart/form-data | |||
There was a problem hiding this comment.
could u also verify if this is working once :) thanks
app/(default)/api/leads/route.ts
Outdated
| if (!deletedLead) { | ||
| return NextResponse.json({ error: "Lead not found" }, { status: 404 }); | ||
| } | ||
|
|
||
| // If there's an image URL, delete it from Cloudinary | ||
| if (deletedLead.imageURL) { | ||
| if (deletedLead.imageUrl) { |
There was a problem hiding this comment.
Are the fields changed now? i dont get why this change was ncessary! .........same here as well!! Check if this is working
app/(default)/api/leads/route.ts
Outdated
| const newLead = new Leadsmodel({ | ||
| id: leadID, | ||
| ...leadData, | ||
| }); | ||
|
|
||
| // If image URL is provided, upload it to Cloudinary and convert to WebP |
There was a problem hiding this comment.
is this change necessary? I dont see how this change from the previous codebase needed this extra logic for saving img
app/(default)/api/leads/route.ts
Outdated
| @@ -168,7 +190,23 @@ export async function PUT(request: Request) { | |||
| { ...leadData }, | |||
| { new: true } | |||
| ); | |||
|
|
|||
|
|
|||
this pr converts the pictures used in the website to .webp format
the hardcoded pictures were replaced with their .web versions.
Implemented automatic webP conversion for images using "webpImages" function for the ones being retrieved from cloudinary.
the pr fixes issue #256