v0.9.1 #195
Merged
v0.9.1 #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some flawed logic resulted in a loss of fidelity on location for some violations. a set of callbacks now exist to try and locate the exact location. New Files Created (2) 1. schema_validation/property_locator.go (292 lines) - Core error extraction and YAML navigation logic - 10 functions with single responsibilities - Performance optimized (pre-compiled regex, efficient string building) 2. schema_validation/property_locator_test.go (820 lines) - 31 comprehensive tests (27 unit + 4 integration) - Tests for all edge cases, nil safety, not found scenarios - Issue #726 integration tests included Modified Files (2) 3. schema_validation/validate_document.go (+5 lines) - Integrated fallback logic at lines 75-117 - Optimized: extracts property info once before loop (O(m+n) not O(n*m)) 4. schema_validation/validate_schema.go (+3 lines) - Integrated fallback logic at lines 270-333 - Same optimization applied
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #195 +/- ##
==========================================
+ Coverage 97.34% 97.43% +0.08%
==========================================
Files 42 43 +1
Lines 3761 3892 +131
==========================================
+ Hits 3661 3792 +131
Misses 100 100
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a fix for daveshanley/vacuum#726
A more robust lookup,
PropertyNameInfoattempts to provide a valid lookup.