Fix REST request validation by directly checking $_SERVER vars #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Line 75, `$request = new WP_REST_Request();` creates a new WP_Rest_Request without parameters and so it's effectively empty, but then the rest of the function behaves as if it wasn't empty leading to a situation where you can't delete a card.
Resolved specific problems in request validation logic that were identified by automated checks, including ensuring the HTTP request method is properly checked and content type validation is case-insensitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related tickets & documents
None
Description
This pull request addresses a critical flaw in the
validate_requestmethod where it incorrectly assumed the state of a newly instantiatedWP_REST_Requestobject without parameters. Originally, the method attempted to validate the request method and content type using this uninitialized object, leading to a logical mistake where the validation could never properly execute due to the absence of correctly set values within theWP_REST_Requestobject.Key Changes:
WP_REST_Requestobject for method and content type checks.$_SERVERglobal for 'REQUEST_METHOD' and 'CONTENT_TYPE'.