Added customer introduction to the paytrail payments page #130
Conversation
Also replaced some compiling packets since the ones in the plugin were no longer supported
| }; | ||
|
|
||
| const closeOverlay = () => { | ||
| console.log('Closing overlay'); |
| const credentialButton = document.getElementById('credentials'); | ||
| const testModeButton = document.getElementById('test-mode-button'); | ||
| const testModeCheckbox = document.getElementById('woocommerce_paytrail_enable_test_mode'); | ||
| const mainForm = document.getElementById('mainform'); |
There was a problem hiding this comment.
mainForm does not appear to be used
| * Enqueue jQuery from WordPress core | ||
| */ | ||
| public function enqueue_jquery() { | ||
| wp_enqueue_script('jquery'); |
There was a problem hiding this comment.
I think this can be improved by the checking which admin page is in the $hook_suffix and ensuring we only add the scripts to the necessary pages. https://developer.wordpress.org/reference/hooks/admin_enqueue_scripts/
| /** | ||
| * Enqueue jQuery UI from WordPress core | ||
| */ | ||
| public function enqueue_jquery_ui() { |
There was a problem hiding this comment.
Same as comment on enqueue_jquery()
| @@ -1932,40 +2141,66 @@ public function handle_custom_searches( $query, $query_vars) { | |||
| return $query; | |||
| } | |||
|
|
|||
| public function enqueue_admin_scripts() { | |||
There was a problem hiding this comment.
As per comments on plugin.php, there is the $hook_suffix parameter passed to this that can be used to only action on the required pages.
| }, | ||
| "scripts": { | ||
| "test": "echo \"Error: no test specified\" && exit 1", | ||
| "watch": "webpack --watch", | ||
| "dev": "webpack", | ||
| "build": "webpack -p" | ||
| "build": "webpack" |
There was a problem hiding this comment.
See my comment on webpack.config.js, I'm not familiar with it so just noting I've not reviewed changes related to this
There was a problem hiding this comment.
Can't review due to the large diff size. So just nothing that. I'm not familiar with what this file is used for either.
There was a problem hiding this comment.
Another I can't review due to the size change diff and also not familiar with the file
There was a problem hiding this comment.
Another I can't review due to the size change diff and also not familiar with the file
There was a problem hiding this comment.
I think this is just auto generated so not reviewed.
Also replaced some compiling packets since the ones in the plugin were no longer supported