Skip to content

php stan fixes #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Darkiii666 wants to merge 31 commits into
base: main
Choose a base branch
from
Open

php stan fixes #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
322d800
First refund amount values
a-zagroba Jul 28, 2025
6779193
First refund amount values
a-zagroba Jul 28, 2025
d1434d7
Merge branch 'paysera:main' into main
Darkiii666 Jul 29, 2025
07d4c9d
Revert changes
a-zagroba Jul 29, 2025
0571df2
Merge remote-tracking branch 'origin/main'
a-zagroba Jul 29, 2025
269cd0a
Revert changes
a-zagroba Jul 29, 2025
d04af5c
Revert changes
a-zagroba Jul 29, 2025
88e2b7a
Revert changes
a-zagroba Jul 29, 2025
5f67dc5
Revert changes
a-zagroba Jul 29, 2025
15f7289
Revert changes
a-zagroba Jul 29, 2025
ad39bc5
Added refund commission amount and currency
a-zagroba Jul 30, 2025
9905357
Docs update
a-zagroba Jul 30, 2025
5f93c92
Docs update
a-zagroba Jul 30, 2025
c8fe5b6
Docs update
a-zagroba Jul 30, 2025
02a9cb3
Docs update
a-zagroba Jul 30, 2025
3a11954
Docs update
a-zagroba Jul 30, 2025
355e417
Docs update
a-zagroba Jul 30, 2025
75f6a46
Docs update
a-zagroba Jul 30, 2025
a7a036a
Merge remote-tracking branch 'origin/main'
a-zagroba Jul 30, 2025
984ac30
Fix typing
a-zagroba Jul 30, 2025
f15a5bf
Added Refund entity
a-zagroba Jul 30, 2025
bb4b9a9
Added Refund entity
a-zagroba Jul 30, 2025
3406a0e
Added Refund entity
a-zagroba Jul 30, 2025
b38e875
Added test
a-zagroba Jul 31, 2025
f9d0b34
bump web to pay
a-zagroba Jul 31, 2025
6a5ed5c
bump web to pay
a-zagroba Jul 31, 2025
ad92662
Revert
a-zagroba Jul 31, 2025
bd40b7d
Php stan fixes
a-zagroba Jul 31, 2025
bcfb8c7
Merge remote-tracking branch 'origin/main'
a-zagroba Jul 31, 2025
d2c0baf
Php stan fixes
a-zagroba Jul 31, 2025
71256da
Php stan fixes
a-zagroba Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,26 +60,6 @@ parameters:
count: 1
path: src/Provider/WebToPay/Adapter/PaymentRedirectRequestNormalizer.php

-
message: "#^Method Paysera\\\\CheckoutSdk\\\\Provider\\\\WebToPay\\\\Adapter\\\\PaymentValidationResponseNormalizer\\:\\:denormalize\\(\\) has parameter \\$providerResponse with no value type specified in iterable type array\\.$#"
count: 1
path: src/Provider/WebToPay/Adapter/PaymentValidationResponseNormalizer.php

-
message: "#^Method Paysera\\\\CheckoutSdk\\\\Provider\\\\WebToPay\\\\Adapter\\\\PaymentValidationResponseNormalizer\\:\\:getOrderFromProviderResponse\\(\\) has parameter \\$providerResponse with no value type specified in iterable type array\\.$#"
count: 1
path: src/Provider/WebToPay/Adapter/PaymentValidationResponseNormalizer.php

-
message: "#^Method Paysera\\\\CheckoutSdk\\\\Provider\\\\WebToPay\\\\Adapter\\\\PaymentValidationResponseNormalizer\\:\\:getProviderProperty\\(\\) has no return type specified\\.$#"
count: 1
path: src/Provider/WebToPay/Adapter/PaymentValidationResponseNormalizer.php

-
message: "#^Method Paysera\\\\CheckoutSdk\\\\Provider\\\\WebToPay\\\\Adapter\\\\PaymentValidationResponseNormalizer\\:\\:getProviderProperty\\(\\) has parameter \\$providerResponse with no value type specified in iterable type array\\.$#"
count: 1
path: src/Provider/WebToPay/Adapter/PaymentValidationResponseNormalizer.php

-
message: "#^Method Paysera\\\\CheckoutSdk\\\\Service\\\\TranslatableLogoInterface\\:\\:getLogos\\(\\) return type with generic class Paysera\\\\CheckoutSdk\\\\Entity\\\\Collection\\\\TranslationCollection does not specify its types\\: Translation$#"
count: 1
Expand Down
2 changes: 0 additions & 2 deletions src/Entity/PaymentCallbackValidationResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,6 @@ class PaymentCallbackValidationResponse

private ?string $type = null;

private ?string $refundTimestamp = null;

public function __construct(int $projectId, Order $order, int $status)
{
$this->projectId = $projectId;
Expand Down
13 changes: 13 additions & 0 deletions src/Provider/WebToPay/Adapter/PaymentValidationResponseNormalizer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ public function __construct(TypeConverter $typeConverter)
$this->typeConverter = $typeConverter;
}

/**
* @param array<string, mixed> $providerResponse
*/
public function denormalize(array $providerResponse): PaymentCallbackValidationResponse
{
$order = $this->getOrderFromProviderResponse($providerResponse);
Expand Down Expand Up @@ -50,6 +53,9 @@ public function denormalize(array $providerResponse): PaymentCallbackValidationR
;
}

/**
* @param array<string, mixed> $providerResponse
*/
protected function getRefundFromProviderResponse(array $providerResponse): ?Refund
{
if (!isset($providerResponse['refund_timestamp'])) {
Expand All @@ -64,6 +70,9 @@ protected function getRefundFromProviderResponse(array $providerResponse): ?Refu
);
}

/**
* @param array<string, mixed> $providerResponse
*/
protected function getOrderFromProviderResponse(array $providerResponse): Order
{
$order = new Order(
Expand All @@ -83,6 +92,10 @@ protected function getOrderFromProviderResponse(array $providerResponse): Order
;
}

/**
* @param array<string, mixed> $providerResponse
* @return mixed
*/
protected function getProviderProperty(
string $propertyName,
array $providerResponse,
Expand Down