Clean up Analytics Names #313
Conversation
| @@ -113,19 +113,19 @@ public class CardClient: NSObject { | |||
| return | |||
| } | |||
|
|
|||
| analyticsService?.sendEvent("card-payments:3ds:confirm-payment-source:challenge-required") | |||
| analyticsService?.sendEvent("card-payments:confirm-payment-source:challenge-required") | |||
There was a problem hiding this comment.
On Android we do have every event related to approveOrder() named with approve-order. Here's an example in CardAnalytics.kt.
There was a problem hiding this comment.
Yes, I had opened a PR yesterday to rename these events but closed it and wanted to just clean up things that were mislabeled as "3ds" in this PR. I wanted to hold off other changes until we have alignment in iOS/Android on analytic events.
| completion(nil, error) | ||
| } | ||
|
|
||
| private func notifyCheckoutCancelWithError(with error: CoreSDKError, completion: (CardResult?, CoreSDKError?) -> Void) { | ||
| analyticsService?.sendEvent("card-payments:3ds:challenge:user-canceled") | ||
| analyticsService?.sendEvent("card-payments:approve-order:challenge:user-canceled") |
There was a problem hiding this comment.
This one seems like it deviates a bit from the rest. Everything else seems to have the format <MODULE>:<FEATURE>:<EVENT_NAME>. Would card-payments:approve-order:user-canceled-challenge work?
There was a problem hiding this comment.
I was thinking of changing both "card-payments:vault-wo-purchase:challenge:canceled" and this one to
"card-payments: approve-order:auth-challenge:canceled"
"card-payments: vault-wo-purchase:auth-challenge:canceled"
But I wanted to do overhaul in another PR after we have resolution between iOS and Android analytics.
This PR is correcting incorrectly named "3ds" events.
There was a problem hiding this comment.
Ok cool. This makes sense for now 👍
There was a problem hiding this comment.
Ty, Steven. Yeah, checking with analytics folks to coordinate name changing before merging anything. It totally makes sense to use approve-order.
But I wanted to make all the final changes in a different PR.
|
I am going to go ahead and put draft of changes for iOS here and will confirm with analytics team and Steven before merging. I think it'd be better than having to communicate changes twice. |
Summary of changes
<module>: <function>: <event>vo-purchseinstead of justvaultto distinguish it from vault with purchase flowChanges:
Card ApproveOrder:
Removed:
card-payments:3ds:confirm-payment-source:succeededcard-payments:3ds:confirm-payment-source:failedAdded:
card-payments:approve-order:auth-challenge-succeededfor card approval success with 3dscard-payments:approve-order:auth-challenge-failedfor card approval failure with 3dsRenamed:
card-payments:3ds:started=>card-payments:approve-order:startedcard-payments:3ds:confirm-payment-source:challenge-required->card-payments:approve-order:auth-challenge-requiredcard-payments:3ds:failed(this was previously used for both 3ds and non-3ds final result) ->card-payments:approve-order:failedcard-payments:3ds:succeeded(this was previously used for both 3ds and non-3ds final result) ->card-payments:approve-order:succeededcard-payments:approve-order:challenge:user-canceled=>card-payments:approve-order:auth-challenge-canceledcard-payments:3ds:challenge-presentation:succeeded=>card-payments:approve-order:auth-challenge-presentation:succeededcard-payments:3ds:challenge-presentation:failed=>card-payments:approve-order:auth-challenge-presentation:failedCard Vault:
Added:
card-payments:vault-wo-purchase:auth-challenge-succeededfor card vault success with 3dscard-payments:vault-wo-purchase:auth-challenge-failedfor card vault failure with 3dsRenamed:
card-payments:3ds:challenge-presentation:challenge-required=>card-payments:vault-wo-purchase:auth-challenge-requiredcard-payments:3ds:challenge-presentation:succeeded=>card-payments:vault-wo-purchase:auth-challenge-presentation:succeededcard-payments:3ds:challenge-presentation:failed=>card-payments:vault-wo-purchase:auth-challenge-presentation:failedcard-payments:vault-wo-purchase:challenge:canceled=>card-payments:vault-wo-purchase:auth-challenge-canceledRemains same:
card-payments:vault-wo-purchase:succeededcard-payments:vault-wo-purchase:failedcard-payments:vault-wo-purchase:startedMain changes are having consistent analytic names across iOS and Android and separate success/fail end events for 3ds and non-3ds flows.
This is a draft as result of discussion with @sshropshire on cleaning up and coordinating iOS and Android analytic events
Checklist
- [ ] Added a changelog entryAuthors