Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes for adding properties to callog to track rac timestamp value #391

Merged
merged 8 commits into from
Sep 26, 2024
Merged

changes for adding properties to callog to track rac timestamp value #391

merged 8 commits into from
Sep 26, 2024

Conversation

rasamala83
Copy link
Collaborator

No description provided.

@rasamala83
Copy link
Collaborator Author

rasamala83 commented Apr 18, 2024 •
edited
Loading

This change adds an extra 80 to 95 bytes for every RAC_ID cal event. This event triggers only in case of any RAC maintenance.

Sample:
E18:17:19.76 RAC_ID 0 0 poolModName=hera-test&workerId=0&shardId=0&tm=1712926025&exitTime=1712926087&exitInSec=48sec
E18:17:19.76 RAC_ID 0 0 poolModName=hera-test&workerId=0&shardId=0&tm=1712926025&exitTime=1712926135&exitInSec=96sec
E18:17:19.76 RAC_ID 0 0 poolModName=hera-test&workerId=0&shardId=0&tm=1712926025&exitTime=1712926183&exitInSec=144sec
E18:17:19.76 RAC_ID 0 0 poolModName=hera-test&workerId=0&shardId=0&tm=1712926025&exitTime=1712926231&exitInSec=192sec

venkatsridhar95
venkatsridhar95 reviewed Apr 26, 2024
View reviewed changes
lib/workerpool.go Outdated Show resolved Hide resolved
venkatsridhar95
venkatsridhar95 reviewed Apr 26, 2024
View reviewed changes
lib/workerpool.go Outdated Show resolved Hide resolved
ModEtchFill
ModEtchFill approved these changes Sep 2, 2024
View reviewed changes
Copy link
Contributor

@ModEtchFill ModEtchFill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not possible to add automated tests since RAC isn't in the express edition that github actions workflows tests on. Approving on my end to avoid blocking your internal steps.

ishi-0987
ishi-0987 approved these changes Sep 25, 2024
View reviewed changes
Copy link
Collaborator

@ishi-0987 ishi-0987 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@rasamala83 rasamala83 merged commit 4af3606 into paypal:main Sep 26, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkatsridhar95 venkatsridhar95 venkatsridhar95 left review comments

@ModEtchFill ModEtchFill ModEtchFill approved these changes

@ishi-0987 ishi-0987 ishi-0987 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rasamala83 @ishi-0987 @ModEtchFill @venkatsridhar95 @rajesh-1983