Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update devdocker go-lang, avoid 32bit overflow #381

Merged
merged 5 commits into from
Dec 19, 2023

Conversation

ModEtchFill
Copy link
Contributor

@ModEtchFill ModEtchFill commented Dec 14, 2023

For #380

Tested to work outside of corporate proxy

In the future, we'll switch from docker to podman, nerdctl, or SuSE rancher work-alikes.

@ModEtchFill
Copy link
Contributor Author

Looks like #379 pull request's java ci failures aren't fixed by the tests/devdocker fix in this pull request

19:36:41.508 [main] DEBUG com.paypal.hera.jdbc.UtilHeraBox - #10 [5/6] RUN go get github.com/go-sql-driver/mysql
19:36:42.624 [main] DEBUG com.paypal.hera.jdbc.UtilHeraBox - #10 1.151 # filippo.io/edwards25519
Error: 19:36:42.624 [main] DEBUG com.paypal.hera.jdbc.UtilHeraBox - #10 1.151 src/filippo.io/edwards25519/scalar.go:166:53: cannot convert x (type []byte) to type *[32]byte

https://github.com/paypal/hera/actions/runs/7213475681/job/19653966130

@ModEtchFill
Copy link
Contributor Author

After docker_build_and_run dockerfile update, Java CI fails on

pq: duplicate key value violates unique constraint "test_postgres_txn_pkey"
at com.paypal.hera.client.HeraClientImpl.check_error(HeraClientImpl.java:738)
at com.paypal.hera.client.HeraClientImpl.execDML(HeraClientImpl.java:470)
at com.paypal.hera.jdbc.HeraStatement.helperExecuteUpdate(HeraStatement.java:157)
at com.paypal.hera.jdbc.HeraPreparedStatement.executeUpdate(HeraPreparedStatement.java:164)
at com.paypal.hera.jdbc.PostgresTxnTest.test_postgres_txn(PostgresTxnTest.java:152)

@ModEtchFill
Copy link
Contributor Author

ModEtchFill commented Dec 18, 2023

Elsewhere SQLException is used for constraint violation https://github.com/paypal/hera/blob/main/client/java/jdbc/src/test/java/com/paypal/hera/jdbc/ClientTest.java#L719

Hrm. But HeraClientException, HeraExceptionBase are subclasses of SQLException

@ModEtchFill ModEtchFill merged commit f17e94f into paypal:main Dec 19, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants