feat(richtext-lexical): support escaping markdown characters #11784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GermanJablo
reviewed
Mar 19, 2025
packages/richtext-lexical/src/packages/@lexical/markdown/MarkdownImport.ts
Show resolved
Hide resolved
GermanJablo
reviewed
Mar 19, 2025
packages/richtext-lexical/src/packages/@lexical/markdown/MarkdownImport.ts
Outdated
Show resolved
Hide resolved
GermanJablo
reviewed
Mar 19, 2025
GermanJablo
approved these changes
Mar 20, 2025
|
I know this is urgent to fix our docs, but it would be nice if once facebook/lexical#2715 is merged, we could get rid of this code. It's easy to forget to do that. I suggest not closing #10289 yet and leaving an explanatory comment there. |
There is one other blocker that prevents us from getting rid of this code: @lexical/markdown still depends on @lexical/code, which will break node when executed from a standalone script |
|
🚀 This is included in version v3.29.0 |
kendelljoseph
pushed a commit
that referenced
this pull request
Mar 31, 2025
Fixes #10289 and #11772 This adds support for escaping markdown characters. For example,` \*` is supposed to be imported as `*` and exported back to `\*`. Equivalent PR in lexical repo: facebook/lexical#7353
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10289 and #11772
This adds support for escaping markdown characters. For example,
\*is supposed to be imported as*and exported back to\*.Equivalent PR in lexical repo: facebook/lexical#7353