Skip to content

Correct FFI bindings monitor method name#1562

Merged
arminsabouri merged 1 commit into
payjoin:masterfrom
xstoicunicornx:ffi-correct-monitor-name
May 16, 2026
Merged

Correct FFI bindings monitor method name#1562
arminsabouri merged 1 commit into
payjoin:masterfrom
xstoicunicornx:ffi-correct-monitor-name

Conversation

@xstoicunicornx
Copy link
Copy Markdown
Collaborator

Summary

Correct the payjoin FFI bindings Monitor::monitor method name to Monitor::check_payment as this:

  • keeps it consistent with base payjoin package
  • accurately reflects the purpose of the method

It was confirmed that this correction is needed here.

Please confirm the following before requesting review:

@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 25945055866

Coverage remained the same at 85.293%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13667
Covered Lines: 11657
Line Coverage: 85.29%
Coverage Strength: 395.83 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Collaborator

@arminsabouri arminsabouri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack ebe849e

@arminsabouri arminsabouri merged commit b90f245 into payjoin:master May 16, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants