Skip to content

Add C# SDK to nix dev shell#1559

Draft
chavic wants to merge 1 commit into
payjoin:masterfrom
chavic:chavic/csharp-nix-devshell
Draft

Add C# SDK to nix dev shell#1559
chavic wants to merge 1 commit into
payjoin:masterfrom
chavic:chavic/csharp-nix-devshell

Conversation

@chavic
Copy link
Copy Markdown
Collaborator

@chavic chavic commented May 15, 2026

Agents and contributors using nix could not run the C# binding tests because dotnet was not provided by the dev shell. The C# test script generates bindings and then runs dotnet test, so nix should provide the SDK used by the repo.

  • add the .NET 8 SDK to the default nix development shell
  • document the nix command for running the C# binding test script

Closes #1555

Validation

  • nix --extra-experimental-features "nix-command flakes" fmt -- --ci
  • nix --extra-experimental-features "nix-command flakes" develop -c bash payjoin-ffi/csharp/contrib/test.sh

Disclosure: co-authored by Codex

Include the .NET 8 SDK in the default nix development shell so local C# binding tests can run without relying on host tools.

Document the nix command that generates the bindings and runs the C# test suite.
@coveralls
Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 25926790907

Coverage remained the same at 85.293%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 13667
Covered Lines: 11657
Line Coverage: 85.29%
Coverage Strength: 395.85 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Collaborator

@spacebear21 spacebear21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

concept ACK but @nothingmuch brought up out of band that dotnet-sdk_8 is considered insecure and furthermore we should set DOTNET_CLI_TELEMETRY_OPTOUT in the devshell in dotnet-sdk_10

@chavic
Copy link
Copy Markdown
Collaborator Author

chavic commented May 15, 2026

concept ACK but @nothingmuch brought up out of band that dotnet-sdk_8 is considered insecure and furthermore we should set DOTNET_CLI_TELEMETRY_OPTOUT in the devshell in dotnet-sdk_10

I see, considering making dotnet-sdk_10 the default, the case for dotnet-sdk_8 was compatibility, hopefully 8 has faded out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support C# build & test in nix

3 participants