Add C# SDK to nix dev shell#1559
Draft
chavic wants to merge 1 commit into
Draft
Conversation
Include the .NET 8 SDK in the default nix development shell so local C# binding tests can run without relying on host tools. Document the nix command that generates the bindings and runs the C# test suite.
Collaborator
Coverage Report for CI Build 25926790907Coverage remained the same at 85.293%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
spacebear21
requested changes
May 15, 2026
Collaborator
spacebear21
left a comment
There was a problem hiding this comment.
concept ACK but @nothingmuch brought up out of band that dotnet-sdk_8 is considered insecure and furthermore we should set DOTNET_CLI_TELEMETRY_OPTOUT in the devshell in dotnet-sdk_10
Collaborator
Author
I see, considering making dotnet-sdk_10 the default, the case for dotnet-sdk_8 was compatibility, hopefully 8 has faded out |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents and contributors using nix could not run the C# binding tests because
dotnetwas not provided by the dev shell. The C# test script generates bindings and then runsdotnet test, so nix should provide the SDK used by the repo.Closes #1555
Validation
nix --extra-experimental-features "nix-command flakes" fmt -- --cinix --extra-experimental-features "nix-command flakes" develop -c bash payjoin-ffi/csharp/contrib/test.shDisclosure: co-authored by Codex