Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update websocket library. #64

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Update websocket library. #64

merged 2 commits into from
Dec 30, 2022

Conversation

pavoni
Copy link
Owner

@pavoni pavoni commented Dec 29, 2022

The library we were using was very old - and was stale for a long time.

But the great news is that https://github.com/websocket-client/websocket-client is now active - and has several years worth of bugfixes!

I'm hopeful it will close #54

This will require some testing!

@pavoni
Copy link
Owner Author

pavoni commented Dec 29, 2022

@doctorfree Do you have a view on this?

I'm tempted to merge and release a version using the new library - since it makes it easier to test in HA.

But don't want to mess up you or users of https://github.com/doctorfree/RoonCommandLine

@doctorfree
Copy link
Contributor

I don't have a very good understanding of the changes involved in moving to the newer WebSocket client for Python. My initial impression is this would not impact RoonCommandLine. Regardless, my view is to improve the Python Roon API library and I will adjust accordingly as necessary.

@pavoni
Copy link
Owner Author

pavoni commented Dec 29, 2022

Thanks - I guess it’s mostly just a pretty big version change - so perhaps risky.

I’ll do some more testing, it did work out the box though.

Once it looks good - I’ll build a library - and ask you to check it out.

@pavoni
Copy link
Owner Author

pavoni commented Dec 30, 2022

This is already looking good. It recovers reliably to a local roon core on my dev machine - which I can't get the old library to do.

@pavoni pavoni merged commit 442b710 into master Dec 30, 2022
@pavoni pavoni deleted the update-websocket-library branch December 30, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After a lengthy disconnection with many retries - socket connection doesn't recover
2 participants