Fix crash when attempting to play a tag #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a crash when playing a tag like this:
roon.play_media(zone_id, ["Library", "Tags", "mytag"])
This does not fix the playing of the tag (that still doesn't work), but
it prevents a KeyError exception from being thrown because the "hint"
field doesn't exist.
Related to pavoni#59
|
Would you like me to merge this - or would you like to wait for your full fix to allow tags to play? If you'd like to merge - would you mind adding a comment to the get to explain why it's needed? Will just help someone coming to it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a crash when playing a tag like this:
This does not fix the playing of the tag (that still doesn't work), but it prevents a KeyError exception from being thrown because the "hint" field doesn't exist.
Related to #59