Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve flatten args in error context transformer #678

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

DavidBadura
Copy link
Member

No description provided.

@DavidBadura DavidBadura added the bug Something isn't working label Jan 17, 2025
@DavidBadura DavidBadura added this to the 3.8.0 milestone Jan 17, 2025
@DavidBadura DavidBadura merged commit 0498a7a into 3.8.x Jan 17, 2025
28 of 29 checks passed
@DavidBadura DavidBadura deleted the improve-flatten-args branch January 17, 2025 10:46
Copy link

github-actions bot commented Jan 17, 2025

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 979.300μs (±0.00%) | 1.060ms (±0.00%)   | -7.61%    | 34.632mb        | 34.640mb   | -0.02%      |
| benchLoad10000Events ()                | 51.241ms (±0.00%)  | 51.783ms (±0.00%)  | -1.05%    | 34.632mb        | 34.640mb   | -0.02%      |
| benchSave1Event ()                     | 983.900μs (±0.00%) | 922.200μs (±0.00%) | +6.69%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000Events ()                | 229.619ms (±0.00%) | 230.242ms (±0.00%) | -0.27%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.014s (±0.00%)    | 8.711s (±0.00%)    | -8.01%    | 34.128mb        | 34.128mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.915s (±0.00%)    | 4.917s (±0.00%)    | -0.04%    | 34.128mb        | 34.128mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 53.387ms (±0.00%)  | 52.174ms (±0.00%)  | +2.32%    | 34.132mb        | 34.132mb   | 0.00%       |
| benchLoad10000Events ()                | 920.800μs (±0.00%) | 972.300μs (±0.00%) | -5.30%    | 34.132mb        | 34.132mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 75.776ms (±0.00%) | 78.192ms (±0.00%) | -3.09%    | 34.596mb        | 34.596mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.170s (±0.00%) | 3.199s (±0.00%) | -0.90%    | 46.745mb        | 46.745mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 870.400μs (±0.00%) | 890.400μs (±0.00%) | -2.25%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchLoad10000Events ()                | 86.863ms (±0.00%)  | 88.709ms (±0.00%)  | -2.08%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave1Event ()                     | 1.484ms (±0.00%)   | 1.470ms (±0.00%)   | +0.95%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave10000Events ()                | 252.143ms (±0.00%) | 261.175ms (±0.00%) | -3.46%    | 35.259mb        | 35.259mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.104s (±0.00%)   | 12.431s (±0.00%)   | -2.63%    | 35.258mb        | 35.258mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.096s (±0.00%)    | 9.121s (±0.00%)    | -0.28%    | 35.759mb        | 35.759mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.021ms (±0.00%)   | 1.055ms (±0.00%)   | -3.27%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchLoad10000Events ()                | 58.161ms (±0.00%)  | 60.816ms (±0.00%)  | -4.37%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave1Event ()                     | 1.282ms (±0.00%)   | 1.081ms (±0.00%)   | +18.58%   | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000Events ()                | 309.539ms (±0.00%) | 304.888ms (±0.00%) | +1.53%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.435s (±0.00%)    | 8.236s (±0.00%)    | +2.42%    | 34.242mb        | 34.242mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.150s (±0.00%)    | 5.134s (±0.00%)    | +0.30%    | 34.242mb        | 34.242mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.510ms (±0.00%)   | 4.439ms (±0.00%)   | +1.60%    | 37.435mb        | 37.435mb   | 0.00%       |
| benchSave10000Events () | 351.081ms (±0.00%) | 352.789ms (±0.00%) | -0.48%    | 37.507mb        | 37.506mb   | +0.00%      |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants