Skip to content

Remove hotel_estimate #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

Remove hotel_estimate #81

merged 1 commit into from
May 19, 2025

Conversation

pcothenet
Copy link
Contributor

@pcothenet pcothenet commented May 16, 2025 •
edited
Loading

What

  • Remove hotel_estimate

Why

  • The API has been deprecated

SDK Release Checklist

  • Have you added an integration test for the changes?
  • Have you built the library locally and made queries against it successfully?
  • Did you update the changelog?
  • Did you bump the package version?
  • If endpoints were removed, did you manually remove the corresponding files? (this should be rare)
  • For breaking changes, did you plan for the release of the new SDK versions and deploy the API to production?

pcothenet
pcothenet commented May 16, 2025
View reviewed changes
.flake8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was crapping out and wasn't creating value

@pcothenet pcothenet requested a review from holtbp May 16, 2025 20:46
holtbp
holtbp approved these changes May 19, 2025
View reviewed changes
Copy link
Contributor

@holtbp holtbp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one question about spacing

.pre-commit-config.yaml
rev: "4.0.1"
hooks:
- id: flake8
args: ["--config=.flake8"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

patch_api/api_client.py
@@ -1,12 +1,12 @@
# coding: utf-8
"""
Patch API V2
Patch API V2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tab spacing intentional?

@pcothenet pcothenet merged commit a646d8d into main May 19, 2025
2 checks passed
@pcothenet pcothenet deleted the pc/24 branch May 19, 2025 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holtbp holtbp holtbp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcothenet @holtbp