Skip to content

Conversation

@xd1313113
Copy link
Contributor

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@xd1313113 xd1313113 closed this Sep 5, 2025
@xd1313113 xd1313113 reopened this Sep 5, 2025
@xd1313113 xd1313113 changed the title add conformance test when applying null with operators add conformance test when applying null with plus and minus operators Sep 5, 2025
@xd1313113 xd1313113 changed the title add conformance test when applying null with plus and minus operators add conformance test when applying unknown with plus and minus operators Sep 5, 2025
@XuechunHHH
Copy link
Contributor

We can probably include some NULL/MISSING tests with * and / operator as well in this PR.

Copy link
Contributor

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial set of tests look correct. Let's add some more per Xuechun + my suggestions

@alancai98
Copy link
Contributor

PR is in draft any reason it's still in draft?

@xd1313113 xd1313113 marked this pull request as ready for review September 5, 2025 21:47
@xd1313113
Copy link
Contributor Author

PR is in draft any reason it's still in draft?

Was pending a question and forget to publish the PR

@xd1313113
Copy link
Contributor Author

Should merge after https://github.com/partiql/partiql-lang-kotlin/pull/1826/files is checked in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants